On Tue, Dec 24, 2019 at 4:38 PM Ralph Goers <ralph.go...@dslextreme.com> wrote: > Personally, I would have no problem accepting a contribution that is > backwards compatible and meets ASF requirements; it has to use the > Apache License and the contribution needs to be signed off by anyone > who has copyright claims. That can either be done via one or more ICLAs > or via a software grant. If it is just you then you would just need to sign an > ICLA. Also, we would hope you would stick around to provide support for > the component.
I interpret this as such a contribution will be approved by you from a technical point of view. Please Correct me if I am wrong. I would not prefer to invest my time into such a commitment if that is not the case. My Apache committer username (vy) and track record of support for log4j2-logstash-layout satisfies your other points, I guess. > No, I am just thinking that when storing into ElasticSearch user’s typically > will want the data stored in the manner they want to query it. I know for > my use case I care about the timestamp, formatted message, thread > context data and any event properties. I would want the message portion > formatted using a PatternLayout. I modified the GELF Layout in 2.13.0 to > do that so it pretty much meets my needs to log with Logstash. In fact, the > JSON Layout should be flexible enough that one could configure it to > emulate the GELF format. In its current form, LogstashLayout can (almost) very well render the GELF layout[1]. There are only two shortcomings: 1) epoch seconds with fraction and 2) using PatternLayout while rendering messages. But no worries, I will address them[2,3] in a couple of days. [1] https://docs.graylog.org/en/3.1/pages/gelf.html#gelf-payload-specification [2] https://github.com/vy/log4j2-logstash-layout/issues/48 [3] https://github.com/vy/log4j2-logstash-layout/issues/49
