These tests have been removed. On Mon, Mar 12, 2018 at 10:58 AM, Remko Popma <remko.po...@gmail.com> wrote:
> Matt is right on all counts. The tests can be removed since picocli is > tested in its own project, and when we split the modules it can be moved > out of core into the tools module. > > > > > On Mar 12, 2018, at 8:03, Matt Sicker <boa...@gmail.com> wrote: > > > > Is that test copied from picocli? If so, I’m not sure what the value is > > there anyways since it’s already tested in its own project. As for why > it’s > > included, it won’t need to be once all the command line tools are > separated > > (this includes custom loggers and levels besides just log receivers and > > whatnot); then it can go with the tools specifically. It doesn’t add much > > overhead to embed it (seems to be one of the main purposes of the > library). > > > > On Sun, Mar 11, 2018 at 14:40, Ralph Goers <ralph.go...@dslextreme.com> > > wrote: > > > >> I’m not sure what you are thinking. > >> > >> Ralph > >> > >>> On Mar 11, 2018, at 12:10 PM, Gary Gregory <garydgreg...@gmail.com> > >> wrote: > >>> > >>> Could it be a Maven toolchain that is misconfigured? > >>> > >>> Gary > >>> > >>> On Sun, Mar 11, 2018, 13:01 Ralph Goers <ralph.go...@dslextreme.com> > >> wrote: > >>> > >>>> I should also add that this test is not failing on the MacBook Pro > that > >> I > >>>> use to perform releases. It is failing on a MacBook Pro that is about > 4 > >>>> years newer. But both are running the latest version of High Sierra > and > >>>> should be configured similarly. The only major difference is that I > use > >>>> Java 8 on the laptop where it fails and Java 7 on the laptop where it > >> works. > >>>> > >>>> Ralph > >>>> > >>>>> On Mar 11, 2018, at 11:57 AM, Ralph Goers < > ralph.go...@dslextreme.com> > >>>> wrote: > >>>>> > >>>>> I can’t answer that except to say that I don’t think that will change > >>>> for 2.11.0. I have no idea why we have anything to do with the > command > >>>> line in Log4j. > >>>>> > >>>>> Ralph > >>>>> > >>>>>> On Mar 11, 2018, at 11:42 AM, Gary Gregory <garydgreg...@gmail.com> > >>>> wrote: > >>>>>> > >>>>>> Do we still even need Picocli in the core? (This whole time I > thought > >> it > >>>>>> was "picoli") > >>>>>> > >>>>>> Gary > >>>>>> > >>>>>> > >>>>>> On Sun, Mar 11, 2018, 12:06 Ralph Goers <ralph.go...@dslextreme.com > > > >>>> wrote: > >>>>>> > >>>>>>> I do not know why but now on one of my MacBooks the 2.x build is > >>>> failing > >>>>>>> with > >>>>>>> > >>>>>>> [INFO] Running > >>>> org.apache.logging.log4j.core.tools.picocli.CommandLineTest > >>>>>>> [ERROR] Tests run: 199, Failures: 1, Errors: 0, Skipped: 4, Time > >>>> elapsed: > >>>>>>> 0.802 s <<< FAILURE! - in > >>>>>>> org.apache.logging.log4j.core.tools.picocli.CommandLineTest > >>>>>>> [ERROR] > >>>>>>> > >>>> > >> testInetAddressConvertersInvalidError(org.apache.logging. > log4j.core.tools.picocli.CommandLineTest) > >>>>>>> Time elapsed: 0.077 s <<< FAILURE! > >>>>>>> java.lang.AssertionError: Invalid format %$::a?*!a was accepted for > >>>>>>> -InetAddress > >>>>>>> at > >>>>>>> > >>>> > >> org.apache.logging.log4j.core.tools.picocli.CommandLineTest. > parseInvalidValue(CommandLineTest.java:496) > >>>>>>> at > >>>>>>> > >>>> > >> org.apache.logging.log4j.core.tools.picocli.CommandLineTest. > testInetAddressConvertersInvalidError(CommandLineTest.java:480) > >>>>>>> > >>>>>>> [INFO] > >>>>>>> [INFO] Results: > >>>>>>> [INFO] > >>>>>>> [ERROR] Failures: > >>>>>>> [ERROR] > >>>>>>> > >>>> > >> CommandLineTest.testInetAddressConvertersInvalidError:480-> > parseInvalidValue:496 > >>>>>>> Invalid format %$::a?*!a was accepted for -InetAddress > >>>>>>> [INFO] > >>>>>>> [ERROR] Tests run: 199, Failures: 1, Errors: 0, Skipped: 4 > >>>>>>> > >>>>>>> Ralph > >>>>>>> > >>>>>>>> On Mar 9, 2018, at 12:23 PM, Gary Gregory <garydgreg...@gmail.com > > > >>>>>>> wrote: > >>>>>>>> > >>>>>>>> On Thu, Mar 8, 2018 at 9:48 PM, Ralph Goers < > >>>> ralph.go...@dslextreme.com> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> I have created the release notes for 2.11.0. Please review them. > >>>>>>>>> > >>>>>>>>> I have built the 2.11.0 web site locally and am noticing the > >>>> following > >>>>>>>>> problems: > >>>>>>>>> > >>>>>>>>> The javadoc page does not list jdbc-dbc2, jpa, or liquibase. > >>>>>>>>> The link on the javadco page for MongoDB results in a 404. I > >> suspect > >>>>>>>>> because there should be a link for mongodb2 and mongodb3. > >>>>>>>>> The link on the left nav to MongoDB results in a 404. There are > no > >>>> links > >>>>>>>>> to MongoDB2 or 3. > >>>>>>>>> The left nav does not contain a link to JPA. > >>>>>>>>> > >>>>>>>>> I have uploaded the site to > >>>>>>> http://rgoers.github.io/log4j2-site/index.html > >>>>>>>>> <http://rgoers.github.io/log4j2-site/index.html>. Please review > it > >>>> for > >>>>>>>>> other problems. > >>>>>>>>> > >>>>>>>> > >>>>>>>> I fixed a few things. Please check it out. > >>>>>>>> > >>>>>>>> Gary > >>>>>>>> > >>>>>>>> > >>>>>>>>> > >>>>>>>>> Ralph > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>>> > >>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> > >> > >> > >> -- > > Matt Sicker <boa...@gmail.com> >
