Re: [VOTE] Release Log4j 2.10.0-rc1

Mikael Ståldal Mon, 20 Nov 2017 11:44:09 -0800

It is. But how common is it that people download the source of aparticular release? I think that most people either download the binaryartifacts, or build the source from latest master branch (and there itis already fixed).

Maybe we can include something about this in the release notes, thatthis unit test might fail in Windows.

It is unfourtante that our release process is so heavy that it takes ~1hour to make another RC, but that's the way it (currently) is.



On 2017-11-20 20:33, Gary Gregory wrote:

It's just lame that if someone downloads the source they cannot even build
it :-(

Gayr

On Mon, Nov 20, 2017 at 2:28 PM, Mikael Ståldal <mi...@apache.org> wrote:

I agree with Ralph.

On 2017-11-20 20:03, Ralph Goers wrote:

Unless you find something else I am not inclined to rerun the release
just to fix a unit test where we know what the problem is and that has no
impact on the code customers use.

Ralph

On Nov 20, 2017, at 11:56 AM, Gary Gregory <garydgreg...@gmail.com>

wrote:

On Mon, Nov 20, 2017 at 10:43 AM, Gary Gregory <garydgreg...@gmail.com>
wrote:

Here it is:


[ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
1.469 s <<< FAILURE! - in org.apache.log4j.config.
Log4j1ConfigurationFactoryTest
[ERROR] testSystemProperties1(org.apache.log4j.config.
Log4j1ConfigurationFactoryTest)  Time elapsed: 0.027 s  <<< ERROR!
java.nio.file.FileSystemException:
C:\Users\ggregory\AppData\Local\Temp\hadoop.log: The process cannot
access the file because it is being used by another process.

         at org.apache.log4j.config.Log4j1ConfigurationFactoryTest
.testSystemProperties1(Log4j1ConfigurationFactoryTest.java:173)


I think Remko fixed that in master.

Building master with 'mvn clean install' passes so I would prefer another
RC that picks up Remko's fix.

Gary

Gary

On Mon, Nov 20, 2017 at 9:41 AM, Gary Gregory <garydgreg...@gmail.com>
wrote:

Wow,


Now I get a different failure. I had run the build in Windows but from
the git command line (MINGW64). That that I run from a "real" Windows
command line I get:

[ERROR] Errors:
[ERROR]   Log4j1ConfigurationFactoryTest.testSystemProperties1:173 »
FileSystem C:\Users...
[INFO]
[ERROR] Tests run: 145, Failures: 0, Errors: 1, Skipped: 0
[INFO]

Gary

On Mon, Nov 20, 2017 at 4:40 AM, Remko Popma <remko.po...@gmail.com>
wrote:

Ran another build from the release tag, with Java 7. Build succeeds.


I'll look at the checksums and the site next.

Gary, could you run another clean build?
The error messages look strange: I cannot see any difference between
the
expected and the actual result in the error output...



Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-11T01:41:47+09:00)
Maven home: C:\apps\apache-maven-3.3.9\bin\..
Java version: 1.7.0_55, vendor: Oracle Corporation
Java home: C:\apps\jdk1.7.0_55\jre
Default locale: en_US, platform encoding: MS932
OS name: "windows 8.1", version: "6.3", arch: "amd64", family:
"windows"

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Log4j 2 ..................................... SUCCESS [
3.940 s]
[INFO] Apache Log4j API Java 9 support .................... SUCCESS [
12.324 s]
[INFO] Apache Log4j API ................................... SUCCESS [
36.662 s]
[INFO] Apache Log4j Core .................................. SUCCESS
[22:30
min]
[INFO] Apache Log4j Core Integration Tests ................ SUCCESS
[01:26
min]
[INFO] Apache Log4j 1.x Compatibility API ................. SUCCESS [
19.337 s]
[INFO] Apache Log4j SLF4J Binding ......................... SUCCESS [
10.867 s]
[INFO] Apache Log4j to SLF4J Adapter ...................... SUCCESS [
5.751 s]
[INFO] Apache Log4j Commons Logging Bridge ................ SUCCESS [
5.527 s]
[INFO] Apache Log4j Flume Bridge .......................... SUCCESS [
35.251 s]
[INFO] Apache Log4j Web ................................... SUCCESS [
13.574 s]
[INFO] Apache Log4j Tag Library ........................... SUCCESS [
24.771 s]
[INFO] Apache Log4j JMX GUI ............................... SUCCESS [
2.966 s]
[INFO] Apache Log4j Samples ............................... SUCCESS [
0.846 s]
[INFO] Apache Log4j Samples: Flume - Common ............... SUCCESS [
4.211 s]
[INFO] Apache Log4j Samples: Flume - Remote ............... SUCCESS [
3.523 s]
[INFO] Apache Log4j Samples: Flume - Embedded ............. SUCCESS [
9.808 s]
[INFO] Apache Log4j Samples: Configuration ................ SUCCESS [
4.508 s]
[INFO] Apache Log4j Samples: LoggerProperties ............. SUCCESS [
4.883 s]
[INFO] Apache Log4j OSGi .................................. SUCCESS [
9.422 s]
[INFO] Apache Log4j BOM ................................... SUCCESS [
1.082 s]
[INFO] Apache Log4j CouchDB ............................... SUCCESS [
2.306 s]
[INFO] Apache Log4j MongoDB ............................... SUCCESS [
4.873 s]
[INFO] Apache Log4j Cassandra ............................. SUCCESS [
27.022 s]
[INFO] Apache Log4J Performance Tests ..................... SUCCESS [
58.354 s]
[INFO] Apache Log4j Streaming Interface ................... SUCCESS [
15.511 s]
[INFO] Apache Log4j JUL Adapter ........................... SUCCESS [
15.085 s]
[INFO] Apache Log4j Liquibase Binding ..................... SUCCESS [
4.396 s]
[INFO] Apache Log4j App Server Support .................... SUCCESS [
1.993 s]
[INFO]
------------------------------------------------------------
------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------
------------
[INFO] Total time: 29:39 min
[INFO] Finished at: 2017-11-20T20:25:57+09:00
[INFO] Final Memory: 55M/451M
[INFO]
------------------------------------------------------------
------------


On Mon, Nov 20, 2017 at 5:06 PM, Remko Popma <remko.po...@gmail.com>
wrote:

On Nov 20, 2017, at 15:21, Ralph Goers <ralph.go...@dslextreme.com>

wrote:


Oh, and I wouldn’t be surprised if the problem is caused by you
using

MS932 and Greg using cp1252.

  From Gary’s error messages  it seems more like a white space/newline

issue

which is odd  because it works on my Windows and the tests use
String.format with %n to avoid this exact issue.

Ralph


On Nov 19, 2017, at 11:12 PM, Remko Popma <remko.po...@gmail.com>

wrote:

Building current master (211326b) succeeds for me when running `mvn

clean

verify` on


Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-11T01:41:47+09:00)
Maven home: C:\apps\apache-maven-3.3.9\bin\..
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: C:\apps\jdk1.8.0_131\jre
Default locale: en_US, platform encoding: MS932
OS name: "windows 10", version: "10.0", arch: "amd64", family:
"dos"

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Log4j 2 .....................................

SUCCESS [

7.669 s]

[INFO] Apache Log4j API Java 9 support .................... SUCCESS

15.544 s]

[INFO] Apache Log4j API ...................................

SUCCESS [

39.700 s]

[INFO] Apache Log4j Core ..................................
SUCCESS

[20:39

min]

[INFO] Apache Log4j Core Integration Tests ................ SUCCESS

[01:11

min]

[INFO] Apache Log4j 1.x Compatibility API ................. SUCCESS

20.190 s]

[INFO] Apache Log4j SLF4J Binding ......................... SUCCESS

12.041 s]

[INFO] Apache Log4j to SLF4J Adapter ...................... SUCCESS

7.408 s]

[INFO] Apache Log4j Commons Logging Bridge ................ SUCCESS

6.109 s]

[INFO] Apache Log4j Flume Bridge .......................... SUCCESS

35.029 s]

[INFO] Apache Log4j Web ...................................

SUCCESS [

14.350 s]

[INFO] Apache Log4j Tag Library ........................... SUCCESS

23.264 s]

[INFO] Apache Log4j JMX GUI ...............................

SUCCESS [

2.881 s]

[INFO] Apache Log4j Samples ...............................

SUCCESS [

0.649 s]

[INFO] Apache Log4j Samples: Flume - Common ............... SUCCESS

3.368 s]

[INFO] Apache Log4j Samples: Flume - Remote ............... SUCCESS

3.873 s]

[INFO] Apache Log4j Samples: Flume - Embedded ............. SUCCESS

8.254 s]

[INFO] Apache Log4j Samples: Configuration ................ SUCCESS

5.707 s]

[INFO] Apache Log4j Samples: LoggerProperties ............. SUCCESS

5.481 s]

[INFO] Apache Log4j OSGi ..................................

SUCCESS [

10.065 s]

[INFO] Apache Log4j BOM ...................................

SUCCESS [

1.030 s]

[INFO] Apache Log4j CouchDB ...............................

SUCCESS [

2.694 s]

[INFO] Apache Log4j MongoDB ...............................

SUCCESS [

5.229 s]

[INFO] Apache Log4j Cassandra ............................. SUCCESS

26.357 s]

[INFO] Apache Log4J Performance Tests ..................... SUCCESS

[01:01

min]

[INFO] Apache Log4j Streaming Interface ................... SUCCESS

19.790 s]

[INFO] Apache Log4j JUL Adapter ........................... SUCCESS

17.716 s]

[INFO] Apache Log4j Liquibase Binding ..................... SUCCESS

4.818 s]

[INFO] Apache Log4j App Server Support .................... SUCCESS

2.434 s]

[INFO]
------------------------------------------------------------

------------

[INFO] BUILD SUCCESS

[INFO]
------------------------------------------------------------

------------

[INFO] Total time: 27:57 min

[INFO] Finished at: 2017-11-20T14:56:18+09:00
[INFO] Final Memory: 56M/518M
[INFO]
------------------------------------------------------------

------------



On Mon, Nov 20, 2017 at 2:10 PM, Remko Popma <

remko.po...@gmail.com>

wrote:

When I upgraded picocli to 2.0.3 a few weeks ago I made sure all

tests

passed on Windows. CI builds are ok.


I also did a successful Log4j2 build on Windows yesterday when

looking

at

pull request #134.


This is very odd.


On Nov 20, 2017, at 12:49, Ralph Goers <

ralph.go...@dslextreme.com>

wrote:


All of these errors seem to be against a single test class which

tests

the help text of the command line tool. Frankly, I don’t even know

what

that tool does. Second, I’ve not had any problems on MacOS nor seem

complaints on Linux. Have you run a full build on Windows since

JCommander

replaced Piccoli? Does the command line tool still work or is this

just a

problem with the tests not behaving correctly on Windows (which is

what I

suspect)?


Ralph

On Nov 19, 2017, at 6:32 PM, Gary Gregory <

garydgreg...@gmail.com>

wrote:

-1

  From src zip: ASC OK, MD5 OK, SHA1 OK.

Building with 'mvn clean verify' using:

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T03:58:13-04:00)
Maven home: C:\Java\apache-maven-3.5.2
Java version: *1.7.0_80*, vendor: *Oracle* Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family:

"windows"

I get the following ERRORs:

[ERROR] Tests run: 136, Failures: 17, Errors: 0, Skipped: 1,
Time

elapsed:

0.6 s <<< FAILURE! - in

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpTest
[ERROR]
testSynopsisOrderCorrectWhenParametersDeclaredOutOfOrder(

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<[<main class> <param0> <param1>]

but was:<[<main class> <param0> <param1>]

     at

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testSynopsisOrderCorrectWhenParametersDeclaredOutOfOrder(

CommandLineHelpTest.java:2014)

[ERROR]
testDefaultParameterRenderer_rendersSpecifiedMarkerForParam

etersWithPositiveArity(org.apache.logging.log4j.core.tools.p

icocli.

CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [*, , , <required>,

required]:

arrays first differed at element [0]; expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpecifiedMarkerForParam

etersWithPositiveArity(CommandLineHelpTest.java:1020)

Caused by: java.lang.AssertionError: expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpecifiedMarkerForParam

etersWithPositiveArity(CommandLineHelpTest.java:1020)

[ERROR]
testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithDefaultValue(org.apache.logging.log4j.

core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0.017 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [ , -b, ,, -a,
--alpha=<otherField>, other]: arrays first differed at element

[0];

expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithDefaultValue(CommandLineHelpTest.java:990)

Caused by: java.lang.AssertionError: expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithDefaultValue(CommandLineHelpTest.java:990)

[ERROR]
testDefaultParameterRenderer_rendersSpacePrefixForParameter

sWithZeroArity(org.apache.logging.log4j.core.tools.

picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [, , , <optional>,

optional]:

arrays first differed at element [3]; expected:<<optional>> but

was:<<optional>>
     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpacePrefixForParameter

sWithZeroArity(

CommandLineHelpTest.java:1035)

Caused by: java.lang.AssertionError: expected:<<optional>> but

was:<<optional>>
     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpacePrefixForParameter

sWithZeroArity(

CommandLineHelpTest.java:1035)

[ERROR]
testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithDefault(org.apache.logging.log4j.core.tools.

picocli.
CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [*, -b, ,, -a,
--alpha=<otherField>, other]: arrays first differed at element

[0];

expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithDefault(CommandLineHelpTest.java:944)

Caused by: java.lang.AssertionError: expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithDefault(CommandLineHelpTest.java:944)

[ERROR]
testSynopsisOrderCorrectWhenSubClassAddsParameters(org.

apache.logging.log4j.core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<[<main class> <param0> <param1> <param2> <param3>]

but was:<[<main class> <param0> <param1> <param2> <param3>]

     at

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testSynopsisOrderCorrectWhenSubClassAddsParameters(

CommandLineHelpTest.java:2028)

[ERROR]
testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithoutDefault(org.apache.logging.log4j.core.tools

.picocli.

CommandLineHelpTest)

Time elapsed: 0.004 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [*, -b, ,, -a,
--alpha=<otherField>, other]: arrays first differed at element

[0];

expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithoutDefault(CommandLineHelpTest.java:960)

Caused by: java.lang.AssertionError: expected:<*> but was:<*>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpecifiedMarkerForRequi

redOptionsWithoutDefault(CommandLineHelpTest.java:960)

[ERROR]
testSubclassAttributesOverrideEmptySuper(org.apache.logging.

log4j.core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<[base]

but was:<[base]

     at

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testSubclassAttributesOverrideEmptySuper(

CommandLineHelpTest.java:1902)

[ERROR]
testDefaultParameterRenderer_rendersSpacePrefixByDefaultFor

ParametersWithPositiveArity(org.apache.logging.log4j.core.

tools.picocli.

CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [ , , , <required>,

required]:

arrays first differed at element [0]; expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpacePrefixByDefaultFor

ParametersWithPositiveArity(CommandLineHelpTest.java:1005)

Caused by: java.lang.AssertionError: expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_rendersSpacePrefixByDefaultFor

ParametersWithPositiveArity(CommandLineHelpTest.java:1005)

[ERROR]
testDefaultOptionRenderer_rendersCommaOnlyIfBothShortAnd

LongOptionNamesExist(org.apache.logging.log4j.core.tools.

picocli.
CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [, -v, , ,

shortBool]:

arrays

first differed at element [1]; expected:<-v> but was:<-v>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersCommaOnlyIfBothShortAnd

LongOptionNamesExist(CommandLineHelpTest.java:1065)

Caused by: java.lang.AssertionError: expected:<-v> but was:<-v>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersCommaOnlyIfBothShortAnd

LongOptionNamesExist(CommandLineHelpTest.java:1065)

[ERROR]
testDefaultOptionRenderer_rendersShortestOptionNameThenO

therOptionNamesAndDescription(org.apache.logging.log4j.core.

tools.picocli.

CommandLineHelpTest)

Time elapsed: 0.016 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [, -L, ,,

---long=<longField>,

long description]: arrays first differed at element [1];

expected:<-L>

but

was:<-L>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersShortestOptionNameThenO

therOptionNamesAndDescription(CommandLineHelpTest.java:922)

Caused by: java.lang.AssertionError: expected:<-L> but was:<-L>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersShortestOptionNameThenO

therOptionNamesAndDescription(CommandLineHelpTest.java:922)

[ERROR]
testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithoutDefaultValue(org.apache.logging.log4j.

core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [ , -b, ,, -a,
--alpha=<otherField>, other]: arrays first differed at element

[0];

expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithoutDefaultValue(CommandLineHelpTest.java:974)

Caused by: java.lang.AssertionError: expected:< > but was:< >

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_rendersSpacePrefixByDefaultFor

RequiredOptionsWithoutDefaultValue(CommandLineHelpTest.java:974)

[ERROR]
testDefaultOptionRenderer_omitsDefaultValuesForBooleanFi

elds(org.apache.logging.log4j.core.tools.picocli.CommandLine

HelpTest)

Time elapsed: 0.017 s  <<< FAILURE!

org.junit.internal.ArrayComparisonFailure: [, -v, , ,

shortBool]:

arrays

first differed at element [1]; expected:<-v> but was:<-v>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_omitsDefaultValuesForBooleanFi

elds(CommandLineHelpTest.java:1099)

Caused by: java.lang.AssertionError: expected:<-v> but was:<-v>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultOptionRenderer_omitsDefaultValuesForBooleanFi

elds(CommandLineHelpTest.java:1099)

[ERROR]
testAttributesInheritedWhenSubclassingForReuse(org.apache.

logging.log4j.core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<[base]

but was:<[base]

     at

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testAttributesInheritedWhenSubclassingForReuse(

CommandLineHelpTest.java:1862)

[ERROR]
testDefaultParameterRenderer_showsParamLabelIfPresentOrFiel

dNameOtherwise(org.apache.logging.log4j.core.tools.

picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:  <longField> expected:<

<longField>[]>

but

was:< <longField>[]>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_showsParamLabelIfPresentOrFiel

dNameOtherwise(

CommandLineHelpTest.java:1128)

[ERROR]
testDefaultParameterRenderer_appliesToPositionalArgumentsIg

noresSeparator(org.apache.logging.log4j.core.tools.

picocli.CommandLineHelpTest)

Time elapsed: 0.004 s  <<< FAILURE!

org.junit.ComparisonFailure: POSITIONAL_ARGS

expected:<POSITIONAL_ARGS[]>

but was:<POSITIONAL_ARGS[]>

     at
org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testDefaultParameterRenderer_appliesToPositionalArgumentsIg

noresSeparator(

CommandLineHelpTest.java:1145)

[ERROR]
testSubclassAttributesOverrideSuperValues(org.apache.

logging.log4j.core.tools.picocli.CommandLineHelpTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<[sub]

but was:<[sub]

     at

org.apache.logging.log4j.core.tools.picocli.CommandLineHelpT
est.

testSubclassAttributesOverrideSuperValues(

CommandLineHelpTest.java:1937)

[INFO] Running org.apache.logging.log4j.core.

tools.picocli.CommandLineTest

[ERROR] Tests run: 199, Failures: 3, Errors: 0, Skipped: 4, Time

elapsed:

0.857 s <<< FAILURE! - in

org.apache.logging.log4j.core.tools.picocli.CommandLineTest
[ERROR]
testCallReturnsNullAndPrintsErrorIfParseFails(org.apache.

logging.log4j.core.tools.picocli.CommandLineTest)

Time elapsed: 0.04 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<...t a number"
Usage: [<main class> [-number=<number>]
   -number=<number>]

but was:<...t a number"

Usage: [<main class> [-number=<number>]
   -number=<number>]

at

org.apache.logging.log4j.core.tools.picocli.CommandLineTest.

testCallReturnsNullAndPrintsErrorIfParseFails(

CommandLineTest.java:2318)

[ERROR]
testIssue148InfiniteLoop(org.apache.logging.log4j.core.

tools.picocli.CommandLineTest)

Time elapsed: 0.02 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<Usage: [<main class> [--foo-bar-baz=<foo>]
   --foo-bar-baz=<foo>]       Default:
...> but was:<Usage: [<main class> [--foo-bar-baz=<foo>]
   --foo-bar-baz=<foo>]       Default:
...>
     at
org.apache.logging.log4j.core.tools.picocli.CommandLineTest.

testIssue148InfiniteLoop(CommandLineTest.java:2478)

[ERROR]
testRunPrintsErrorIfParseFails(org.apache.logging.log4j.

core.tools.picocli.CommandLineTest)

Time elapsed: 0 s  <<< FAILURE!

org.junit.ComparisonFailure:
expected:<...t a number"
Usage: [<main class> [-number=<number>]
   -number=<number>]

but was:<...t a number"

Usage: [<main class> [-number=<number>]
   -number=<number>]

at

org.apache.logging.log4j.core.tools.picocli.CommandLineTest.

testRunPrintsErrorIfParseFails(CommandLineTest.java:2282)

Gary



On Sun, Nov 19, 2017 at 11:11 AM, Ralph Goers <

ralph.go...@dslextreme.com <mailto:ralph.go...@dslextreme.com>>

wrote:


This is a vote to release Log4j 2.10.0, the next version of the

Log4j 2

project.


Please download, test, and cast your votes on the log4j

developers

list.

[] +1, release the artifacts

[] -1, don't release because...

The vote will remain open for 72 hours (or more if required).

All

votes

are welcome and we encourage everyone to test the release, but

only

Logging

PMC votes are “officially” counted. As always, at least 3 +1

votes

and

more

positive than negative votes are required.


Note that this release supports SLF4J 1.7.x and SLF4J 1.8.x.

Because

SLF4J

1.7.x requires implementations to include classes in the

org.slf4j.impl

package log4j-sl4j-impl cannot be used as a Java 9 module.

Support

for

SLF4J 1.7.x will be removed in a future release.


Changes in this version include:

New Features

     • LOG4J2-2120: Properly escape newlines and other control
characters in JSON. Thanks to Carter Douglas Kozak.
     • LOG4J2-2109: Add property to disable message pattern

converter

lookups. Thanks to Carter Douglas Kozak.

     • LOG4J2-2112: MapMessage should use deep toString for

values.

Thanks to Carter Douglas Kozak.

     • LOG4J2-2103: XML encoding for PatternLayout.
     • LOG4J2-2114: Provide a native Log4j 2 implementation of

Eclipse

Jetty's org.eclipse.jetty.util.log.Logger.

     • LOG4J2-1203: Allow filtering of line breaks in layout

pattern.

Thanks to Robert Turner.

     • LOG4J2-2098: Add a noop AppenderSkeleton for applications

still

using Log4j 1.x.

     • LOG4J2-2062: Add possibility of sending the key of a

message

to

Kafka using KafkaAppender. Thanks to Jorge Sanchez.

     • LOG4J2-2056: Modularize Log4j-api and make most other

log4j

jars

automatic modules.

     • LOG4J2-1431: Simplify log4j system property naming
scheme.
     • LOG4J2-1809: Add global configuration environment SPI.
     • LOG4J2-1694: Add fields with fixed values to
JSON/XML/YAML
layouts. Thanks to Michal Dvořák.
     • LOG4J2-2054: Provide ways to configure SSL that avoid

plain-text

passwords in the log4j configuration. The configuration may now

specify a

system environment variable that holds the password, or the

path to

file

that holds the password.

     • LOG4J2-2071: Add org.apache.logging.log4j.core.

config.composite.

CompositeConfiguration#toString(). Thanks to Carter Kozak.

Fixed Bugs

     • LOG4J2-2107: MapMessage supports both

StringBuilderFormattable

and MultiformatMessage. Thanks to Carter Douglas Kozak.

     • LOG4J2-2102: MapMessage JSON encoding will escape keys
and
values. Thanks to Carter Douglas Kozak.
     • LOG4J2-2101: Non-string value in MapMessage caused
ClassCastException. Thanks to Carter Douglas Kozak.
     • LOG4J2-2091: Log4j respects the configured

"log4j2.is.webapp"

property Thanks to Carter Douglas Kozak.

     • LOG4J2-2100: LevelMixIn class for Jackson is coded

incorrectly

     • LOG4J2-2087: Jansi now needs to be enabled explicitly (by

setting system property log4j.skipJansi to false). To avoid

causing

problems for web applications, Log4j will no longer

automatically

try

to

load Jansi without explicit configuration. Thanks to Andy

Gumbrecht.

     • LOG4J2-2060: AbstractDatabaseManager should make a copy of

LogEvents before holding references to them: AsyncLogger log

events

are

mutable.

     • LOG4J2-2055: If Log4j is used as the Tomcat logging
implementation startup might fail if an application also uses

Log4j.

     • LOG4J2-2031: Until this change, messages appeared out of

order

in log file any time when the async logging queue was full. With

this

change, messages are only logged out of order to prevent

deadlock

when

Log4j2 detects recursive logging while the queue is full.

     • LOG4J2-2053: Exception java.nio.charset.

UnsupportedCharsetException:

cp65001 in 2.9.0.

     • LOG4J2-1216: Nested pattern layout options broken. Thanks

to

Thies Wellpott, Barna Zsombor Klara, GFriedrich.

     • LOG4J2-2070: Log4j1XmlLayout does not provide the entire

stack

trace, it is missing the caused by information. Thanks to Doug

Hughes.

     • LOG4J2-2036: CompositeConfiguration supports

Reconfiguration.

PR

#115. Thanks to Robert Haycock.

     • LOG4J2-2073: Log4j-config.xsd should make AppenderRef

optional

for each Logger element. Thanks to Patrick Lucas.

Re: [VOTE] Release Log4j 2.10.0-rc1

Reply via email to