I don't know if I'll have time to review any PRs for a few days. Anyone else is welcome to review in the meantime.
On 23 October 2017 at 12:27, kenneth mcfarland <kennethpmcfarl...@gmail.com> wrote: > Hi Matt, I opened a pull request that contains the maven plugin we looked > at. > > See LOG4J2-2086. I tested this locally under the API folder and it rocks. > > I know an IDE can do this, but not an entire repository and force it on > every build. Nobody can manually verify every file or guarantee other > developers will be consistent so this automation is fantastic. > > On Oct 14, 2017 11:44 AM, "kenneth mcfarland" <kennethpmcfarl...@gmail.com > > > wrote: > > > Thank you Matt, I will try provide a patch by the end of the weekend. > > > > Cheers, > > Kenneth > > > > > > On Oct 14, 2017 11:02 AM, "Matt Sicker" <boa...@gmail.com> wrote: > > > >> That looks like it could be useful for sure. It could help avoid merge > >> conflicts. I say go for it and provide a patch! > >> > >> On 13 October 2017 at 21:57, kenneth mcfarland < > >> kennethpmcfarl...@gmail.com> > >> wrote: > >> > >> > My bad, here is a link sir. > >> > > >> > http://code.revelc.net/impsort-maven-plugin/ > >> > > >> > On Fri, Oct 13, 2017 at 7:35 PM, Matt Sicker <boa...@gmail.com> > wrote: > >> > > >> > > What's the plugin? I like the idea in theory at least. I've been > >> dragged > >> > > into import-related formatting wars in past jobs, and having a > >> consistent > >> > > way to handle them would be great (although I think you can > configure > >> > > checkstyle to enforce it, checkstyle doesn't actually format > anything > >> for > >> > > you). > >> > > > >> > > On 13 October 2017 at 20:20, kenneth mcfarland < > >> > > kennethpmcfarl...@gmail.com> > >> > > wrote: > >> > > > >> > > > Greetings, > >> > > > > >> > > > I found what I believe could be a useful plugin to make > consistency > >> > > > requirements with respect to import ordering. This would impose a > >> > strict > >> > > > ordering based on a defined file that stating the rules. This is > >> > > currently > >> > > > used with Apache Fluo, and thought it might be useful here. > >> > > > > >> > > > Before adding a JIRA I felt I would ask the community. Thank you! > >> > > > > >> > > > Sincerely, > >> > > > Kenneth McFarland > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > Matt Sicker <boa...@gmail.com> > >> > > > >> > > >> > >> > >> > >> -- > >> Matt Sicker <boa...@gmail.com> > >> > > > -- Matt Sicker <boa...@gmail.com>
