> On July 4, 2015, 10:17 a.m., Raju Bairishetti wrote: > > pom.xml, line 1390 > > <https://reviews.apache.org/r/36176/diff/1/?file=999110#file999110line1390> > > > > +1 for adding a separate profile for dev build. > > > > IMHO, We can reuse the existing **build section (which is defined > > outside of all profiles common)** instead of re-adding checkstyle, > > findbugs, javadoc plugins in build section of dev profile. > > > > @Yash Can we try by setting the **skipCheck** flag/property in the dev > > profile like this? > > > > <propfile> > > <id>dev</id> > > <properties> > > <skipCheck>true</skipCheck> > > </porpeties> > > </profile> > > > > needs to add <skip>${skipCheck}</skip> in the plugin section.
+1. Added changes. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36176/#review90379 ----------------------------------------------------------- On July 4, 2015, 12:17 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36176/ > ----------------------------------------------------------- > > (Updated July 4, 2015, 12:17 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Adding new profile dev for skipping checks. > > https://issues.apache.org/jira/browse/LENS-641 > > USAGE: > mnv clean install -Pdev > mvn clean install -skipTests -Pdev > > > Diffs > ----- > > pom.xml ee54051 > > Diff: https://reviews.apache.org/r/36176/diff/ > > > Testing > ------- > > Time comparisons- > > mvn clean install > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:06 min > [INFO] Finished at: 2015-07-04T13:54:16+05:30 > [INFO] Final Memory: 125M/400M > [INFO] > ------------------------------------------------------------------------ > > mvn clean install -Pdev > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 15:09 min > [INFO] Finished at: 2015-07-04T14:19:32+05:30 > [INFO] Final Memory: 120M/402M > [INFO] > ------------------------------------------------------------------------ > > mvn clean install -DskipTests > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 04:48 min > [INFO] Finished at: 2015-07-04T14:42:18+05:30 > [INFO] Final Memory: 152M/443M > [INFO] > ------------------------------------------------------------------------ > > mvn clean install -DskipTests -Pdev > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:18 min > [INFO] Finished at: 2015-07-04T14:33:02+05:30 > [INFO] Final Memory: 145M/469M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
