[
https://issues.apache.org/jira/browse/KNOX-2985?focusedWorklogId=889830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-889830
]
ASF GitHub Bot logged work on KNOX-2985:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/23 06:13
Start Date: 10/Nov/23 06:13
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #818:
URL: https://github.com/apache/knox/pull/818#discussion_r1388954480
##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/api/v2/TokenResourceV2.java:
##########
@@ -0,0 +1,146 @@
+/*
Review Comment:
Moved to the same package as `TokenReource` and kept the class name.
Issue Time Tracking
-------------------
Worklog Id: (was: 889830)
Time Spent: 40m (was: 0.5h)
> Deprecate KNOXTOKEN API v1
> --------------------------
>
> Key: KNOX-2985
> URL: https://issues.apache.org/jira/browse/KNOX-2985
> Project: Apache Knox
> Issue Type: Task
> Components: Server, TokenGenerationUI, TokenManagementUI
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In KNOX-2661, the following REST API endpoint changes happened:
> * renew was updated from {{POST}} to {{PUT}}
> * revoke was updated from {{POST}} to {{DELETE}}
> Unfortunately, at that time I did not consider backward compatibility and I
> introduced a backward compatibility issue for clients using previous versions.
> The scope of this Jira is to revert that issue back in the following way:
> * change renew/revoke back to POST in '.../api/v1/token' in v1 (to fix the
> issue we introduced earlier)
> * introduce v2 that will match v1, except that v2 will match the above
> changes from KNOX-2661
> * mark v1 deprecated
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
