[ 
https://issues.apache.org/jira/browse/KNOX-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784441#comment-17784441
 ] 

Sandor Molnar commented on KNOX-2985:
-------------------------------------

I encountered the following in terms of HTTP methods in previous versions in 
"{{{}v1{}}}":
 * 1.5.0  = POST
 * 1.6.x  = PUT/DELETE
 * 2.0.0 = PUT/DELETE
 * 2.1.0 = POST

{{v2}} would only be introduced in 2.1.0.

Since the backward compatibility issue was introduced in 1.6.0, we might 
consider backporting this change, but I don't think it is worth the effort.

I understand that this current change will be incompatible with 1.6.x and 
2.0.0, but I'm convinced we still need to do this. Whoever uses this API will 
only have to switch to {{v2}} if they are upgrading from 1.6.x or 2.0.0. To be 
honest, no one complained about this in the last 2.5 years.

> Deprecate KNOXTOKEN API v1
> --------------------------
>
>                 Key: KNOX-2985
>                 URL: https://issues.apache.org/jira/browse/KNOX-2985
>             Project: Apache Knox
>          Issue Type: Task
>          Components: Server, TokenGenerationUI, TokenManagementUI
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 2.1.0
>
>
> In KNOX-2661, the following REST API endpoint changes happened:
>  * renew was updated from {{POST}} to {{PUT}}
>  * revoke was updated from {{POST}} to {{DELETE}}
> Unfortunately, at that time I did not consider backward compatibility and I 
> introduced a backward compatibility issue for clients using previous versions.
> The scope of this Jira is to revert that issue back in the following way:
>  * change renew/revoke back to POST in '.../api/v1/token' in v1 (to fix the 
> issue we introduced earlier)
>  * introduce v2 that will match v1, except that v2 will match the above 
> changes from KNOX-2661
>  * mark v1 deprecated
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to