Lianet Magrans created KAFKA-20424:
--------------------------------------

             Summary: Review KafkaConsumerTest tests running for Classic only
                 Key: KAFKA-20424
                 URL: https://issues.apache.org/jira/browse/KAFKA-20424
             Project: Kafka
          Issue Type: Test
          Components: clients, consumer
            Reporter: Lianet Magrans


There are several test in KafkaConsumerTests that are currently enabled for the 
Classic consumer only, with a note that states:

 
{code:java}
TODO: this test requires rebalance logic which is not yet implemented in the 
CONSUMER group protocol.
    //       Once it is implemented, this should use both group protocols.{code}
 

 

This is outdated (all the rebalance logic is already implemented in the async 
consumer)

This task is to review the tests that have that comment and we should either:
 * enable them to run for both (classic and async) if the logic applies to 
both, OR
 * remove the comment if the logic is specific to the Classic consumer (e.g, 
the test verifyHeartbeatSent is ok to run for Classic only, that request does 
not exist in the new protocol)

 

Just for context, KafkaConsumerTest contains unit test that applies to both 
consumer, and to the classic only. There is also AsyncKafkaConsumerTest, that 
contains unit tests that are for the async only.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to