Muralidhar Basani created KAFKA-20404:
-----------------------------------------
Summary: Investigate/Fix bulk-excluded SpotBugs atomicity warnings
Key: KAFKA-20404
URL: https://issues.apache.org/jira/browse/KAFKA-20404
Project: Kafka
Issue Type: Improvement
Components: streams
Reporter: Muralidhar Basani
Assignee: Muralidhar Basani
When SpotBugs was upgraded from 4.8.6 to 4.9.4
(https://issues.apache.org/jira/browse/KAFKA-19580 /
https://github.com/apache/kafka/pull/20333/changes), several streams classes
were bulk-excluded for three new atomicity warning patterns.
For ex: StreamThread class is added to exclusion list.
[https://github.com/apache/kafka/blob/1bf7d6032b9b4171f510dc9a1c7e0243410e27f5/gradle/spotbugs-exclude.xml#L636]
Check for Field lastCommitMs
[https://github.com/apache/kafka/blob/1bf7d6032b9b4171f510dc9a1c7e0243410e27f5/streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java#L819]
Each class needs individual investigation to determine whether the warning is a
false positive or a real concurrency bug.
Atomicity warnings to consider :
AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE
AT_NONATOMIC_64BIT_PRIMITIVE
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
There is also a latest version for spotbugs available 4.9.8. See if this can be
upgraded.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
