mimaison commented on code in PR #830: URL: https://github.com/apache/kafka-site/pull/830#discussion_r3027074871
########## Makefile: ########## @@ -1,11 +1,12 @@ # Hugo configuration OUTPUT_DIR := output -HUGO_BASE_IMAGE := hvishwanath/hugo:v0.123.7-ext-multiplatform +HUGO_VERSION := 0.123.7 +HUGO_BASE_IMAGE := ghcr.io/apache/kafka-site/hugo:v$(HUGO_VERSION)-ext-multiplatform DOCKER_IMAGE := $(HUGO_BASE_IMAGE) #PROD_IMAGE := hvishwanath/kafka-site-md:1.2.0 Review Comment: Can we remove this comment too? ########## Makefile: ########## @@ -1,11 +1,12 @@ # Hugo configuration OUTPUT_DIR := output -HUGO_BASE_IMAGE := hvishwanath/hugo:v0.123.7-ext-multiplatform +HUGO_VERSION := 0.123.7 +HUGO_BASE_IMAGE := ghcr.io/apache/kafka-site/hugo:v$(HUGO_VERSION)-ext-multiplatform DOCKER_IMAGE := $(HUGO_BASE_IMAGE) #PROD_IMAGE := hvishwanath/kafka-site-md:1.2.0 PROD_IMAGE := us-west1-docker.pkg.dev/play-394201/kafka-site-md/kafka-site-md:1.6.0 Review Comment: What is `PROD_IMAGE`? Who owns it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
