thomasmueller commented on code in PR #1148:
URL: https://github.com/apache/jackrabbit-oak/pull/1148#discussion_r1357913024


##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndex.java:
##########
@@ -465,6 +465,9 @@ public void remove() {
         @Override
         public IndexRow next() {
             final IndexRow pathRow = pathCursor.next();
+            // we need to copy the reference to the current row here,
+            // otherwise all the returned IndexRows might reference the same 
row
+            final FulltextResultRow currentRow = currentRowInPathIterator;
             return new IndexRow() {
 
                 @Override

Review Comment:
   Yes, that would probably be cleaner... My plan was to create the most simple 
fix, but this seems better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to