[
https://issues.apache.org/jira/browse/HIVE-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116582#comment-14116582
]
Lars Francke commented on HIVE-6123:
------------------------------------
* {{mvn checkstyle:checkstyle}} is a reporting goal, means it builds a HTML
page in the respective {{target/site}} folder.
* {{mvn checkstyle:checkstyle-aggregate generates one HTML report which
combines all the submodule's run.
* {{mvn checkstyle:check}} is run as part of the build and can fail it if
needed. To actually see any output use something like this: {{mvn
checkstyle:check -Phadoop-2 -DskipTests -Dcheckstyle.consoleOutput=true}}
None of these run by default atm. The only one that really makes sense is the
{{check}} goal.
This is an example invocation:
{{mvn compile checkstyle:check -Phadoop-2 -DskipTests
-Dcheckstyle.consoleOutput=true -Dcheckstyle.violationSeverity=warning}}
We could think about something adding this to the build:
{{mvn compile checkstyle:check verify -Phadoop-2 -DskipTests
-Dcheckstyle.consoleOutput=true}}
That'd show the warnings on each build but not fail it. Unfortunately there's
now way to distinguish between "grandfathered" and new code.
> Implement checkstyle in maven
> -----------------------------
>
> Key: HIVE-6123
> URL: https://issues.apache.org/jira/browse/HIVE-6123
> Project: Hive
> Issue Type: Sub-task
> Reporter: Brock Noland
> Assignee: Lars Francke
> Attachments: HIVE-6123.1.patch, HIVE-6123.2.patch
>
>
> ant had a checkstyle target, we should do something similar for maven
--
This message was sent by Atlassian JIRA
(v6.2#6252)
