Hello, For those interested about the full background behind the changes that partially broke StartMiniHS2Cluster please have a look at [1, 2, 3]. If something is not clear or we need to revisit those decisions I am happy to discuss further.
Summarizing in one sentence, the bin.tar.gz and src.tag.gz release artifacts should never contain jars or code which have licenses in Category-X [4]. If we want to use or rely on such code things are a bit more flexible as described in [4]. Best, Stamatis [1] https://lists.apache.org/thread/xd25nhox103t2zj52lnzbjkm6d41ls94 [2] https://issues.apache.org/jira/browse/HIVE-25701 [3] https://issues.apache.org/jira/browse/HIVE-27338 [4] https://www.apache.org/legal/resolved.html#category-x On Wed, Aug 23, 2023 at 11:44 AM Zsolt Miskolczi <zsolt.miskol...@gmail.com> wrote: > > As I understand, they have been removed due to licensing issues. Before we > re-add the jar or add a possibility to include jars into the classpath, I > want to understand the reason. What was the exact licensing issue? > > Do we have to make sure that we don't provide those jars in production? Or > is it necessary for tests as well? > > For me, the solution would be something that I, as a developer, have to set > up one time only. Based on my current knowledge, it seems the ability to > add external jars to the classpath could be more comfortable if we cannot > provide the jars into the production. > The reason is that we need the jdbc driver at two places: > - for MiniHS2 > - and in the conf directory, next to bin (to be able to easily use it for > schema tool, beeline and standalone metastore service). > > > On the other hand, I'm not completely sure if MiniHS2 as a test is the most > comfortable idea. In the long term, I would prefer to replace it with a run > script/configuration that runs Hive Server in a 'Mini' mode, for local > development purposes. > > Thanks, > Zsolt > > > Stamatis Zampetakis <zabe...@gmail.com> ezt írta (időpont: 2023. aug. 22., > K, 18:06): > > > I am not against restoring itest.jdbc.jars property but for this case > > I prefer the explicit declaration of the dependency. > > > > Adding an optional or test scope dependency is much simpler and works > > out of the box. We don't need to download jars manually and we don't > > need to remember how the system property is called in order to run the > > test. > > > > Anyways, we all agree that we want StartMiniHS2Cluster to run on > > different metastore backends so we can create a JIRA/PR and move this > > forward. How we are going to do it is implementation details so we can > > continue the discussion under the respective ticket. > > > > Best, > > Stamatis > > > > On Tue, Aug 22, 2023 at 6:46 PM László Bodor <bodorlaszlo0...@gmail.com> > > wrote: > > > > > > Yeah, I think we should simply re-add the possibility to add jars to > > > classpath, call it "itest.jdbc.jars" to preserve the old behavior and > > > parameter name. > > > > > > Denys Kuzmenko <dkuzme...@apache.org> ezt írta (időpont: 2023. aug. > > 22., K, > > > 12:43): > > > > > > > Instead of adding the dependencies, can't we add the possibility to > > > > include jdbc jars in the classpath? > > > > something like this: > > > > <plugin> > > > > <groupId>org.apache.maven.plugins</groupId> > > > > <artifactId>maven-failsafe-plugin</artifactId> > > > > <executions> > > > > <execution> > > > > <goals> > > > > <goal>integration-test</goal> > > > > <goal>verify</goal> > > > > </goals> > > > > </execution> > > > > </executions> > > > > <configuration> > > > > .... > > > > <additionalClasspathElements> > > > > > > > > > > <additionalClasspathElement>${itest.jdbc.jars}</additionalClasspathElement> > > > > </additionalClasspathElements> > > > > ... > > > > </configuration> > > > > </plugin> > > > > > >
