My concern is that if we have the file there, it should at least compile. I am open to remove the file or move it to somewhere we don't directly support. But right now, it is there in the docker dir so I think it is a reasonable expectation for people to believe it shouldn't throw error just compiling it.
On Sat, May 16, 2020 at 5:21 PM Josh Fischer <[email protected]> wrote: > Would it be that bad if we made a release knowing that we couldn't support > Centos7 or Ubuntu16.04? This would still allow us to get binaries/an > official Docker image/ and install scripts for a few supported operating > systems (Ubuntu 18.x, Debian9, Debian 10, OSX). I remember hearing that > we couldn't release install scripts under Apache, but never really got a > clear answer yet as to why. > > In my opinion the toughest part about building a community around Heron is > because it is not easy to use. Doing a release with binaries I think would > greatly help the community and the current user base (what's left of it). > I believe making a small release like this is a step in the right > direction for the project. > > - Josh > > > > On Sat, May 16, 2020 at 5:03 PM Josh Fischer <[email protected]> wrote: > > > If I were to take a guess I would think it's the line below: But why > this > > folder wouldn't exist I'm unsure of.. > > > > cp -R $(pwd)/external/org_apache_zookeeper/* $TMP_DIR > > > > I've also added the github permalink to the line of code below: > > > > > https://github.com/apache/incubator-heron/blob/2a4f112fc567897711ee7117689e636534cb6fb4/third_party/zookeeper/BUILD#L41 > > > > There is some new conditional logic in that zookeeper rule that may be > > part of the issue. > > > > The link to the conditional in the zookeeper rule is below: > > > > > https://github.com/apache/incubator-heron/blob/2a4f112fc567897711ee7117689e636534cb6fb4/third_party/zookeeper/BUILD#L23 > > > > On Sat, May 16, 2020 at 4:47 PM Ning Wang <[email protected]> wrote: > > > >> Yeah. It's the error when I tried to build on Ubuntu16. The error is in > >> the > >> list of commands which is tricky to debug. There was a similar error > >> message in centos 7 which was caused by cppunit I remember. But it is > hard > >> to tell if it is the same here. > >> > >> On Sat, May 16, 2020 at 2:31 PM Josh Fischer <[email protected]> > wrote: > >> > >> > Hi All, > >> > > >> > I'm checking for OS compatibility with git tag 0.20.3-incubating-rc3 > and > >> > the zookeeper-srcs target is failing to build on Ubuntu 16.04. The > >> > zookeeper-srcs target builds successfully on Mac. So far the only > show > >> > stopping error I can see is that an expected file does not exist in > the > >> > logs. Has anyone run into this issue before? See below for my > >> > terminal output. > >> > > >> > bazel build --config=ubuntu_nostyle > third_party/zookeeper:zookeeper-srcs > >> > > >> > INFO: Options provided by the client: > >> > > >> > Inherited 'common' options: --isatty=1 --terminal_columns=141 > >> > > >> > INFO: Reading rc options for 'build' from > >> > /root/incubator-heron/tools/bazel.rc: > >> > > >> > 'build' options: --genrule_strategy=standalone > --host_force_python=PY2 > >> > --ignore_unsupported_sandboxing --spawn_strategy=standalone > >> > --workspace_status_command scripts/release/status.sh > >> > > >> > INFO: Reading rc options for 'build' from /root/.bazelrc: > >> > > >> > 'build' options: --verbose_failures --spawn_strategy=standalone > >> > --genrule_strategy=standalone --local_ram_resources=4096 > >> > --local_cpu_resources=2 --announce_rc > >> > > >> > INFO: Found applicable config definition build:ubuntu_nostyle in file > >> > /root/incubator-heron/tools/bazel.rc: --genrule_strategy=standalone > >> > --ignore_unsupported_sandboxing --linkopt -lm --linkopt -lpthread > >> --linkopt > >> > -lrt --spawn_strategy=standalone --workspace_status_command > >> > scripts/release/status.sh --copt=-O3 > >> > > >> > INFO: Analyzed target //third_party/zookeeper:zookeeper-srcs (1 > packages > >> > loaded, 2 targets configured). > >> > > >> > INFO: Found 1 target... > >> > > >> > ERROR: /root/incubator-heron/third_party/zookeeper/BUILD:7:1: > Executing > >> > genrule //third_party/zookeeper:zookeeper-srcs failed (Exit 1): bash > >> > failed: error executing command > >> > > >> > (cd > >> > > >> > > >> > /root/.cache/bazel/_bazel_root/88837ab595738499a4ef3075862ee807/execroot/org_apache_heron > >> > && \ > >> > > >> > exec env - \ > >> > > >> > PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin > \ > >> > > >> > /bin/bash -c 'source > >> external/bazel_tools/tools/genrule/genrule-setup.sh; > >> > export > >> INSTALL_DIR=$(pwd)/bazel-out/k8-fastbuild/bin/third_party/zookeeper > >> > > >> > export TMP_DIR=$(mktemp -d -t zookeeper.XXXXX) > >> > > >> > export CXXFLAGS=-Wno-error > >> > > >> > export CFLAGS=-Wno-error > >> > > >> > mkdir -p $TMP_DIR > >> > > >> > cp -R $(pwd)/external/org_apache_zookeeper/* $TMP_DIR > >> > > >> > cd $TMP_DIR/zookeeper-client/zookeeper-client-c > >> > > >> > autoreconf -if > >> > > >> > ./configure --prefix=$INSTALL_DIR --enable-shared=no > >> > > >> > make install > >> > > >> > rm -rf $TMP_DIR') > >> > > >> > Execution platform: @local_config_platform//:host > >> > > >> > cp: cannot stat > >> > > >> > > >> > '/root/.cache/bazel/_bazel_root/88837ab595738499a4ef3075862ee807/execroot/org_apache_heron/external/org_apache_zookeeper/*': > >> > No such file or directory > >> > > >> > Target //third_party/zookeeper:zookeeper-srcs failed to build > >> > > >> > INFO: Elapsed time: 0.815s, Critical Path: 0.06s > >> > > >> > INFO: 0 processes. > >> > > >> > FAILED: Build did NOT complete successfully > >> > > >> > > >
