Ok. We will annotate this way then. I added these lines this way only because no file matches the character. :) Rat simply tries to match every line I remember.
On Wed, Jul 3, 2019 at 1:00 PM Dave Fisher <[email protected]> wrote: > Hi - > > > On Jul 3, 2019, at 10:09 AM, Ning Wang <[email protected]> wrote: > > > > Thanks so much Dave! > > > > Issues are created here: > > https://github.com/apache/incubator-heron/issues/3303 > > https://github.com/apache/incubator-heron/issues/3304 > > https://github.com/apache/incubator-heron/issues/3305 > > > > Quick question, is there an example of the rat-excludes annotation. I > read > > Rat source code before and it seems like the excludes file doesn't > support > > comments. :( > > It does: > > # Files start with . > \..* > .*\.out > > # Data/doc files > .*\.conf > .*\.json > .*\.md > #.*\.txt > .*\.BUILD > .*\.patch > > _helpers\.tpl > autogen\.sh > description > heron\.iml > > See the # comment lines above. > > Regards, > Dave > > > > > > > On Wed, Jul 3, 2019 at 9:36 AM Dave Fisher <[email protected]> > wrote: > > > >> +1 (binding) > >> > >> Signature and checksum is good. > >> DISCLAIMER present > >> LICENSE and NOTICE are there. The third party licenses could use a > little > >> work. The License text should be included in LICENSE or pulled into the > >> licenses directory. Any required copyright attribution should be in the > >> NOTICE. > >> —> Please create an issue to fix these for the next release. > >> RAT Check. The *.md files should have Apache License Headers and > >> CONTRIBUTING.md is link where the target is missing in the release. > >> —> Please create an issue to fix .rat-excludes and fix the md files > license > >> —> Please create an issue to annotate .rat-excludes to explain any that > >> are excludes related to other licensing. > >> > >> Thanks! > >> > >> HTH, > >> Dave > >> > >>> On Jul 2, 2019, at 2:35 PM, Ning Wang <[email protected]> wrote: > >>> > >>> Thanks all for voting! So far we have got 3 +1s. > >>> > >>> I am pinging mentors to give us some binding votes. > >>> > >>> On Tue, Jul 2, 2019 at 1:24 PM Simon Weng <[email protected]> > wrote: > >>> > >>>> +1 > >>>> > >>>> Tested the locally built Heron Docker image. > >>>> > >>>> On Sun, Jun 30, 2019 at 1:45 PM Josh Fischer <[email protected]> > >> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> Rat checks passed > >>>>> Tag built successfully > >>>>> Topology launched successfully > >>>>> Topology killed successfully > >>>>> > >>>>> On Fri, Jun 28, 2019 at 5:32 PM thinker0 <[email protected]> wrote: > >>>>> > >>>>>> +1 > >>>>>> > >>>>>> 2019년 6월 29일 (토) 07:31, Ning Wang <[email protected]>님이 작성: > >>>>>> > >>>>>>> *Hello, Heron Community,This is a call for a vote to the 3rd > release > >>>>>>> candidate for Apache Heron, version v0.20.1-incubating. We kindly > >>>>> request > >>>>>>> project mentors (binded) as well as all contributors (unbinded) and > >>>>> users > >>>>>>> to review and vote on this incubator release.* > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> *The tag to be voted upon:0.20.1-incubating-rc3 > >>>>>>> (40ccec635b45191593ff984a9ae81fd4e0a5dadd)The full list of changes > >>>> and > >>>>>>> release notes are available > >>>>>>> at: > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc3 > >>>>>>> < > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://github.com/apache/incubator-heron/releases/tag/0.20.1-incubating-rc3 > >>>>>>>> Source > >>>>>>> files can be found in dist.apache.org <http://dist.apache.org> > >>>>>>> site: > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-3/ > >>>>>>> < > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/incubator/heron/heron-0.20.1-incubating-candidate-3/ > >>>>>>>> Source > >>>>>>> SHA-512 > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > checksums:68e2d4db598d73dc69e474dc82940402dc4689cc14dda14ad114cbaec79b1b3a8926625083e901f8234631f6345c6aa9e58fc0fec3176fce3e91e041e724d3b8 > >>>>>>> incubator-heron-0.20.1-incubating-rc3.tar.gzPlease download the > >>>> source > >>>>>>> package, and follow the compiling > >>>>>>> guide( > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ > >>>>>>> < > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ > >>>>>>>> )to > >>>>>>> setup environment, build and run locally. Note that currently Bazel > >>>>>> 0.26.0 > >>>>>>> is required to build this version.After Bazel is set up and works > >>>>>>> correctly, you can use these release check scripts > >>>>>>> ( > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks > >>>>>>> < > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > https://github.com/apache/incubator-heron/blob/master/scripts/release_check/README.md#run-individual-release-checks > >>>>>>>> ) > >>>>>>> to verify the build.The vote will be open for at least 72 hours or > >>>>> until > >>>>>>> the necessary number of votes are reached.Please vote > accordingly:[ ] > >>>>> +1 > >>>>>>> approve[ ] +0 no opinion[ ] -1 disapprove with the reasonThanks,The > >>>>>> Apache > >>>>>>> Heron (Incubating) Team* > >>>>>>> > >>>>>> > >>>>> > >>>> > >> > >> > >
