arturobernalg commented on code in PR #657:
URL: 
https://github.com/apache/httpcomponents-core/pull/657#discussion_r3010028569


##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -782,12 +782,17 @@ private void consumeFrame(final RawFrame frame) throws 
HttpException, IOExceptio
         if (frameType == null) {
             return;
         }
+        final long nowNanos = System.nanoTime();

Review Comment:
   @ok2c 
   `nanoTime()` is not better because of finer precision. It is better because 
it is monotonic.
   `currentTimeMillis()` is wall-clock time since the epoch, while `nanoTime()` 
is intended for elapsed-time measurement and uses a monotonic timer; its actual 
resolution still depends on OS and hardware.
   
   https://docs.oracle.com/cd/E15289_01/JRDTG/slow_start.htm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to