adb014 commented on PR #1198:
URL: 
https://github.com/apache/guacamole-client/pull/1198#issuecomment-4222878163

   > Thinking about it, I still have one issue. Guacamole displays the data 
returned by keycloak in the navigation bar, including the "code" field for code 
flow... If the user refreshs the page, as they often do if there is a problem, 
authenticateUser will be called again with the stale code and this will be 
posted to the identity provider. The identity provider detects this as a code 
"reuse" and probably an attack. This is bad
   
   Forget it. I'm an idiot.. The existing js code converts the query parameters 
into a URL fragment so they won't be posted to the server on a refresh.. The 
code as it stands is ok.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to