bbennett-ks opened a new pull request, #656:
URL: https://github.com/apache/guacamole-server/pull/656
The `connection_closing` variable in `rdp.c` (line 627) is not initialized
before use. When RDP event handling fails early in the do-while loop, the code
breaks before `connection_closing` is assigned a value, leading to potentially
aborting a RDP connection because of an error without report the closing as an
error.
This was caused by a fix for GUACAMOLE-2221 (fix RDP busy-loop on transport
failure) which added a break.
I cam across this build Guacamole on Rocky 9.
{code:java}
rdp.c: In function 'guac_rdp_client_thread':
rdp.c:658:12: error: 'connection_closing' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
658 | if (connection_closing)
| ^
rdp.c:627:13: note: 'connection_closing' was declared here
627 | int connection_closing;
| ^~~~~~~~~~~~~~~~~~
{code}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
