bbennett-ks commented on code in PR #1176:
URL: https://github.com/apache/guacamole-client/pull/1176#discussion_r3028586689
##########
guacamole-common-js/src/main/webapp/modules/OnScreenKeyboard.js:
##########
@@ -58,6 +58,23 @@ Guacamole.OnScreenKeyboard = function(layout) {
*/
var pressed = {};
+ /**
+ * Returns if the given keysym is a lock key (Caps Lock,
+ * Num Lock, or Scroll Lock).
+ *
+ * @private
+ * @param {!number} keysym
+ * The keysym to test.
+ *
+ * @returns {!boolean}
+ * true if the keysym is a lock key, false otherwise.
+ */
+ var isToggleLockKeysym = function isToggleLockKeysym(keysym) {
+ return keysym === 0xFFE5 // Caps Lock
+ || keysym === 0xFF7F // Num Lock
+ || keysym === 0xFF14; // Scroll Lock
Review Comment:
Reverted previous change; add new `toggle` parameter to `key` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
