mike-jumper commented on PR #1174:
URL:
https://github.com/apache/guacamole-client/pull/1174#issuecomment-4062204852
I have a couple issues with this:
1. A flag like `metaToCtrl` feels too specific for the core library.
I wouldn't be against some sort of broader keysym filtering callback,
though I'm not sure I see the need to perform filtering directly within
`Guacamole.Keyboard` vs. making the decision in the webapp implementation of
the key event handler.
2. This will cause problems for SSH, etc. when a Mac user hits Cmd+C
expecting to copy but actually terminates the application they're running when
that's transparently translated to Ctrl+C.
It _could_ make sense to provide this as a connection parameter specifically
for VNC and RDP... but:
I think a far better approach would be to find some means of differentiating
between Cmd on a Mac and Meta on a non-Mac. We'd then be able to handle these
events based on the user's expectations, which aligns with guac's general
design around prioritizing key identity (keysym) over location (scancode),
without requiring any manual configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
