bbennett-ks commented on code in PR #642:
URL: https://github.com/apache/guacamole-server/pull/642#discussion_r2922085094
##########
src/terminal/terminal.c:
##########
@@ -1551,7 +1576,7 @@ static int __guac_terminal_send_key(guac_terminal* term,
int keysym, int pressed
return guac_terminal_send_string(term, backspace_str);
}
if (keysym == 0xFF09 || keysym == 0xFF89) return
guac_terminal_send_string(term, "\x09"); /* Tab */
- if (keysym == 0xFF0A) return guac_terminal_send_string(term,
"\x0A"); /* Line Feed */
+ if (keysym == 0xFF0A) return guac_terminal_send_string(term,
"\x0D"); /* Line Feed -> CR */
Review Comment:
This is odd... `GUAC_TERMINAL_ASCII_CR` isn't defined: in `1.6.0` or
`staging/1.6.1`. I added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
