bbennett-ks commented on code in PR #643:
URL: https://github.com/apache/guacamole-server/pull/643#discussion_r2922021794
##########
src/libguac/socket-wsa.c:
##########
@@ -93,7 +93,10 @@ ssize_t guac_socket_wsa_write(guac_socket* socket,
/* Write until completely written */
while (count > 0) {
- int retval = send(data->sock, buffer, count, 0);
+ int retval;
+ do {
+ retval = send(data->sock, buffer, count, 0);
+ } while (retval < 0 && WSAGetLastError() == WSAEINTR);
Review Comment:
Sounds good, add `GUAC_RETRY_UNTIL()` (and use it here) and modify
`GUAC_EINTR_RETRY()` to use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
