Hey, Steven, Thanks - I will probably close the pull request, as this should be resolved by a re-base on top of the current master and then some slight tweaks to the pom.xml. Thanks for catching that, though. In the future, you can probably just comment on the open pull request, instead, and point it out, there, as part of the review process.
Regarding the error messages, yes, more detail is available; however, there are two reasons that detail does not get displayed on the screen: 1) The detail has to be translatable via the built-in translation and exception system. This isn't always the case. 2) Sometimes from a security perspective it's better to tell users more generally that something is not allowed and not share all of the details as to why it isn't allowed. This probably isn't a particularly good or critical case for that, as the users would already be logged in to Guacamole when getting this message about connecting, but I went with that principal :-). -Nick On Thu, Sep 7, 2023 at 12:59 PM Steven Barnhart <[email protected]> wrote: > Thanks for this, I got it built and seemingly working. I submitted a pull > request with some changes I made for it to work for me and with the docker > scripts. I am still very much a git newbie with working with others, so > apologies if it's messy. > > One thing, I am seeing the attached message and seemingly from the logs, > more specific/friendly messages should be displayed? It also doesn't appear > to let me bypass as an admin as I got that message as an admin. We are > using LDAP if that complicates things. > [image: Screenshot 2023-09-07 at 12.50.41 PM.png] > Steve > > > On Fri, Sep 1, 2023 at 10:34 AM Nick Couchman <[email protected]> wrote: > >> On Fri, Sep 1, 2023 at 10:29 AM Steven Barnhart >> <[email protected]> wrote: >> > >> > Oh my you actually implemented what i was going to build (time >> > restrictions)! How awesome! >> > >> >> Yeah, it's been out there as a request for a while, so I took a stab >> at it :-). The extension I implemented allows those limits to be >> placed on connections, connection groups (of the balancing variety), >> users, and user groups. >> >> https://issues.apache.org/jira/projects/GUACAMOLE/issues/GUACAMOLE-1020 >> >> Feel free to try it out and let me know if anything doesn't work as >> expected. >> >> -Nick >> >
