GitHub user hqbhoho edited a discussion: Support high version Trino

New version Trino, Some `ConnectorMetadata` API will change. eg:
In Trino 440
```
    /**
     * Finish insert query
     */
    default Optional<ConnectorOutputMetadata> finishInsert(
            ConnectorSession session,
            ConnectorInsertTableHandle insertHandle,
            List<ConnectorTableHandle> sourceTableHandles,
            Collection<Slice> fragments,
            Collection<ComputedStatistics> computedStatistics)
    {
        throw new TrinoException(GENERIC_INTERNAL_ERROR, "ConnectorMetadata 
beginInsert() is implemented without finishInsert()");
    }
```
but in 435
```
    /**
     * Finish insert query
     */
    default Optional<ConnectorOutputMetadata> finishInsert(
    ConnectorSession session, 
    ConnectorInsertTableHandle insertHandle, 
    Collection<Slice> fragments, 
    Collection<ComputedStatistics> computedStatistics)
    {
        throw new TrinoException(GENERIC_INTERNAL_ERROR, "ConnectorMetadata 
beginInsert() is implemented without finishInsert()");
    }
```
So some SQL will failed because of  incompatible API. 435 is one year ago 
version.

GitHub link: https://github.com/apache/gravitino/discussions/7613

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]

Reply via email to