[ 
https://issues.apache.org/jira/browse/GOSSIP-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137786#comment-16137786
 ] 

ASF GitHub Bot commented on GOSSIP-41:
--------------------------------------

Github user edwardcapriolo commented on a diff in the pull request:

    https://github.com/apache/incubator-gossip/pull/68#discussion_r134644652
  
    --- Diff: 
gossip-base/src/main/java/org/apache/gossip/model/PerNodeDataBulkMessage.java 
---
    @@ -0,0 +1,27 @@
    +package org.apache.gossip.model;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.stream.Collectors;
    +
    +/**
    + * Created by pxsalehi on 22.08.17.
    + */
    +public class PerNodeDataBulkMessage extends Base {
    +    private List<PerNodeDataMessage> messages = new ArrayList<>();
    +
    +    public void addMessage(PerNodeDataMessage msg) {
    +        messages.add(msg);
    +    }
    +
    +    public List<PerNodeDataMessage> getMessages() {
    --- End diff --
    
    Indent is two spaces. Use our style sheet.


> Transfer gossip data in bulk
> ----------------------------
>
>                 Key: GOSSIP-41
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-41
>             Project: Gossip
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Pooya Salehi
>
> Currently the process that transfers shared data and per node data iterates a 
> map transmitting a single datum at a time using one way communication.  We 
> could transmit more key values at once by simply saying if keys < 100 
> transfer all at once, or by collecting keys and sending in groups of 100. 
> This would greatly lower chatter communicating data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to