[
https://issues.apache.org/jira/browse/GOSSIP-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134255#comment-16134255
]
ASF GitHub Bot commented on GOSSIP-38:
--------------------------------------
Github user pxsalehi commented on the issue:
https://github.com/apache/incubator-gossip/pull/67
I have not added a metric since I am not sure how useful it will be.
Similar to elsewhere in the code, I have used an explicit work queue, so that a
metric can be added later easily.
I was not sure if it is a good idea to use the same `ExecutorService` for
both the `GossipMemberStateRefresher` and the listeners. Therefore, I used
separate ones. Kind of similar to what is happening in `SimpleActiveGossiper`
with `threadService`.
> Multiple async GossipListeners
> ------------------------------
>
> Key: GOSSIP-38
> URL: https://issues.apache.org/jira/browse/GOSSIP-38
> Project: Gossip
> Issue Type: New Feature
> Reporter: Edward Capriolo
> Assignee: Pooya Salehi
> Fix For: 0.1.3
>
>
> Currently Gossip allows us to specific 0-1 synchronous event listeners.
> In Hama:
> https://github.com/apache/hama/blob/master/core/src/main/java/org/apache/hama/monitor/fd/NodeEventListener.java
> They can attach multiple async listeners. I like this design better unsure if
> we should support both or only the async kind.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
