[ 
https://issues.apache.org/jira/browse/GOSSIP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113821#comment-16113821
 ] 

Juby Victor commented on GOSSIP-35:
-----------------------------------

Introducing 5 additional parameters into the class will either need an 
overloaded constructor or change the existing constructor. IMHO a constructor 
with 10 parameters is really clumsy, So we have the option of introducing a 
builder, or stick with a 5 param constructor & 10 param constructor. I'm 
inclined to option 1 (Builder). Since there are  only two places which uses the 
settings class, I guess we can bite the bullet on this and make the change to 
use a builder - this should give us some flexibility to introduce other params 
further down the line too...

> Different payloads can be transmitted at different rates
> --------------------------------------------------------
>
>                 Key: GOSSIP-35
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-35
>             Project: Gossip
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Juby Victor
>             Fix For: 0.1.3
>
>
> Current we have a a few ScheduledExectuor one that controls active gossip, 
> one that controls gossip to dead nodes, one that controls gosssip of user 
> data, etc. Currently they all use the same setting to control how often they 
> run (10ms currently). It would be better if they each had their own setting. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to