[ 
https://issues.apache.org/jira/browse/GOSSIP-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061141#comment-16061141
 ] 

ASF GitHub Bot commented on GOSSIP-64:
--------------------------------------

Github user edwardcapriolo commented on a diff in the pull request:

    https://github.com/apache/incubator-gossip/pull/56#discussion_r123779446
  
    --- Diff: gossip-base/src/main/java/org/apache/gossip/crdt/LWWSet.java ---
    @@ -25,7 +25,13 @@
     import java.util.stream.Collectors;
     import java.util.stream.Stream;
     
    -public class LWWSet<ElementType> implements CrdtSet<ElementType, 
Set<ElementType>, LWWSet<ElementType>> {
    +/*
    +  Last write wins CrdtSet. Each operation has timestamp and the latest 
wins.
    --- End diff --
    
    More documentation is needed here. Linking off to meangirls is ok but we 
need to describe the implementation here. What it does when to use it, what are 
issues from clock skew etc.


> Implement Max-Change-Sets 
> --------------------------
>
>                 Key: GOSSIP-64
>                 URL: https://issues.apache.org/jira/browse/GOSSIP-64
>             Project: Gossip
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Maxim Rusak
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to