+1 to Anthony's suggestion I strongly supported the idea behind CODEOWNERS when it was originally implemented, but the reality of the process has been a lot more disruptive to smooth workflows than I anticipated, both as someone who's waiting for code review and as someone who gets tagged to review PRs that I may not actually have context for or expert-level understanding of. ________________________________ From: Anthony Baker <bak...@vmware.com.INVALID> Sent: Wednesday, June 29, 2022 9:33 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: CODEOWNERS? (was Re: Pending PR reviews)
⚠ External Email I realize that this is a thread hijack, but hopefully a useful one. I’ve seen several requests for timely reviews in recent months. I think that the CODEOWNERS goals were important and laudable—directing review requests to those most suited to provide oversight—but the implementation has been problematic. The size, complexity, and interconnectedness of the code base meant that many pull requests tagged not just one expert but just about EVERY expert in the community. This is rather inefficient, to say the least. I propose that we revert CODEOWNERS and return to the review-then-commit model requiring at least one +1 vote from a committer. I see Owen has already created a PR [1] for this change. Thoughts? Anthony [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7820&data=05%7C01%7Cdoevans%40vmware.com%7Cdbae452fb50648fb880208da59ed3a82%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921172683584236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FWL%2Fl5rYbTtIj5mLQXfjNfY2bPcS%2BLTSutwt158sn08%3D&reserved=0 > On Jun 28, 2022, at 5:43 AM, Mario Ivanac <mario.iva...@est.tech> wrote: > > ⚠ External Email > > Hi, > > The following PRs: > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7323&data=05%7C01%7Cdoevans%40vmware.com%7Cdbae452fb50648fb880208da59ed3a82%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921172683584236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V6zOdknmNNf7zDbvy2BS1KFf9JIcdQK7y5qXDDf0aRA%3D&reserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7749&data=05%7C01%7Cdoevans%40vmware.com%7Cdbae452fb50648fb880208da59ed3a82%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921172683584236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VI7lV862yajOMm9aeI0dsDfgpLs1Npor79MoNHR3DDQ%3D&reserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7664&data=05%7C01%7Cdoevans%40vmware.com%7Cdbae452fb50648fb880208da59ed3a82%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921172683584236%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tcgtMT1RcidM3%2B45%2FEqeXSMgvDl0OmUKn8YMNDk9TVA%3D&reserved=0 > > are waiting for review for some time. > > > Could code owners review these PRs? > > Thanks, > Mario > > ________________________________ > > ⚠ External Email: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender.
