On Jan 20, 2021, at 10:36 AM, Owen Nichols <onich...@vmware.com<mailto:onich...@vmware.com>> wrote:
Sounds like good cleanup, but I'm not sure I understand why you propose breaking up the work and sneaking it in through mostly-unrelated PRs? My first thought would be do it in one shot, start by deleting the old constants, and let the compiler guide you to all code that needs pruning. Or, if for some reason it needs to be done/tested iteratively, a feature branch or a long-lived PR might be an appropriate way to segment the work. Just like we don’t cleanup all our code in one giant shot, there is too much to tackle at one time for one person to bite it off. This makes large scale cleanup efforts fail to take off. If however, you are in a chunk of code and the compiler and static analyzers are complaining that the file has things to clean up then we should all be compelled to leave it better than we found it. This proposal lays the ground work to add version checking into this large set of cleanup that needs to happen. While it isn’t ideal for some cleanup to linger it is certainly better to do part now than none at all. -Jake
