Hey, Anil,
It would be really easy to backport. It is needed for the Geode Tomcat Module
to be published to Maven along with the other Geode artifacts. These changes
could be made locally and the artifacts could be published to local Maven or
some other artifactory, but it is easier for the user if they are available
alongside other Geode artifacts in Maven.
There is no user request for this specifically, and we don't need a minor
release of Geode. We just thought it might be nice to include if a minor
version of a past Geode release is created in the future.
________________________________
From: Anilkumar Gingade <aging...@vmware.com>
Sent: Monday, January 11, 2021 2:51 PM
To: dev@geode.apache.org <dev@geode.apache.org>
Subject: Re: [DISCUSSION] Should We Backport Publishing of Geode Tomcat Module
Is there a user request to use this in an older version?
How easy is it to backport?
From the comments, it looks like it is needed for Geode artifacts published to
Maven? Is this true?
If there is no user request, and there is other way to include Tomcat session,
my view is to not backport, but I am not expert in this area, if there is
recommendation to backport, I am fine to. And if it has to be backported, it
should be on the version widely used and above(say 1.10 and above, again
depending on how easy to backport)...
-Anil.
On 1/11/21, 10:10 AM, "Sarah Abbey" <sab...@vmware.com> wrote:
Hey, Geode Devs!
Ben Ross and I are currently working on session state in Geode. In order
to include the Geode Tomcat session module in the Geode artifacts published to
Maven, we had to update the module so it publishes to Maven (as seen in this
PR<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5610&data=04%7C01%7Csabbey%40vmware.com%7C8d448b4e420a41bf675c08d8b66a5e96%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637459915266080526%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TfFGuuUBvatsmnRm71WwT6%2BDrxoaTOW2D1%2FWuFm8ZEs%3D&reserved=0>
and this
PR<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5762&data=04%7C01%7Csabbey%40vmware.com%7C8d448b4e420a41bf675c08d8b66a5e96%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637459915266080526%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=zpmu%2FXD2%2B1qwlb0GAVmqyDfhuTmI6KsIkItfvR6r1%2BY%3D&reserved=0>).
This change is only on the current develop branch. We are now wondering if
these changes should be backported to older versions of Geode.
What does everyone think? If it should be backported, to which versions
should it be backported?
Thank you,
Sarah
