@onichols, to answer your questions: * If there is only one owner, and the owner is on vacation, then a PR will be delayed * If you are an owner, and the only other owner is on vacation, then the PR will be delayed * If one is the sole owner, then the owner-review requirement is not enforced (you can’t review your own PR) * Feel free to start PRs or changes to `features/introduce_codeowners`
From: Owen Nichols <onich...@vmware.com> Date: Wednesday, November 18, 2020 at 8:28 PM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode +1 This will greatly improve the experience for contributors. Instead of an intimidating empty list of reviewers when you submit a PR (and no ability to add reviewers, if you’re not a committer), it will be great to already have at least two reviewers automagically assigned. I have a small concern that initially populating this file via a flurry of PRs may result in a lot of merge conflicts with anyone else that volunteers on the same or an adjacent line. Also, since you _must_ be a committer to be a code owner, is a PR even necessary…would directly committing changes to the feature/introduce-codeowners branch be acceptable? If not, who needs to review and who can merge the PRs against the ‘introduce’ branch? What happens if you are the only owner for an area, can you approve your own PR? Even if the goal is two owners per area, does that mean PRs by either owner cannot be merged if the only other owner is on vacation or otherwise unavailable? Can we submit PRs against the ‘introduce’ branch now and they just won’t be merged before Nov 26, or do we all just need to be patient until this review period has concluded? From: Robert Houghton <rhough...@apache.org> Date: Wednesday, November 18, 2020 at 2:07 PM To: dev@geode.apache.org <dev@geode.apache.org> Subject: [DISCUSS] Adding CODEOWNERS to Apache Geode Hello Devs. I would like to improve the quality of the pull-request reviews we see for critical parts of the Apache Geode project. In discussions with other committers, a (not the) big hurdle to that is getting the right eyes to look at a given PR. To that end, I propose the adoption of GitHub's CODEOWNERS functionality for the Apache Geode code repository. A discussion-document of this issue has been written up by @upthewaterspout. Thanks Dan! https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FIntroduce%2BCodeowners%2Bfile&data=04%7C01%7Crhoughton%40vmware.com%7C78b888ac11b9497a0ebf08d88c437d63%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637413568802236824%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=h7uZXWAqmYrcyry6q5%2BYH4PRrMdSi9egPc3KsD9lPX8%3D&reserved=0 I have tested the feature with fellow Geode committers @upthewaterspout and @onichols-pivotal, and found it to meet our expectations. Please review the document, and comment or reply to this thread, by 25 November, so we might start the task of nominating and applying for ownership. -Robert Houghton
