I can adopt the Junit 4.13 PR! Sarah ________________________________ From: Owen Nichols <onich...@vmware.com> Sent: Wednesday, September 23, 2020 12:41 PM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: [DISCUSS] Someone to update 3rd-party libraries used by Geode
37 dependencies have now been bumped on develop, but I could use some help for the last few. I am looking for volunteers to please "adopt" the six PRs below (leave a comment on the PR indicating you'll take a look). All Geode committers should already have write access to my fork, or email me your github id and I'll invite you as a collaborator (or feel free to create your own PR). Since these are only test dependencies it's not essential that we get to all of them this cycle, but I've set a deadline of Oct 16 to close any that fail to garner attention. 1. Archunit 0.14 introduces some additional checks which currently fail against our codebase. Perhaps someone familiar with membership could take a look at the PR check failures and see if the reported issues are easy to correct or suppress https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5537&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066035341&sdata=M5LAGNt%2BgfE4hc8lz2w%2B1L7cML8t%2FkJeAWUuBcRZ2%2FI%3D&reserved=0 2. Junit 4.13 just needs a few tests' expected-exception handling restructured https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5538&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066035341&sdata=TpdRTmjeGO%2BVjaDz%2FvsJjGwk%2BS59p4xJnKEMNXQLado%3D&reserved=0 3. Assertj 3.17.2 just needs a few deprecated assertions fixed up https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5539&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066040331&sdata=QfWrXrqZjgyqPwBHdtOwjnpa5IvCmfTlTCYzXOr%2FAto%3D&reserved=0 4. Mockito 3.5.11 removed an internal helper method used in one pdx test https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5540&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066040331&sdata=wZ9%2Fx9L88E1DnhlvIeOPV4q%2FfSVyX0KRI70echxGaB8%3D&reserved=0 5. Tomcat 6.0.53 causes two tests to fail https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5541&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066040331&sdata=WJ%2B0w4U2XjcngZVaFIlRISAIpA1pqwD95pHynNPu0%2BI%3D&reserved=0 6. One of the 37 dependency bumps I already did exposed an issue with a management REST test https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F5543&data=02%7C01%7Csabbey%40vmware.com%7Cfd3caf97ce4e49ca135e08d85fdf8eb1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637364761066040331&sdata=NQcT4jrA0v%2BiAD5lhB9uq89P4GAE%2F4q8eUZ6xg%2F89ic%3D&reserved=0 Thanks for any help getting these dependencies bumped for 1.14! -Owen On 9/11/20, 8:31 PM, "Owen Nichols" <onich...@vmware.com> wrote: I'll have a go at it. On 9/10/20, 9:36 AM, "Dave Barnes" <dbar...@apache.org> wrote: Hello Apache Geode Community, We need a volunteer to update the 3rd-party libraries used by Geode. This consists of going through the libraries we depend on and updating each to the latest version that works with our code. It would be nice to get this done within the next week or two so that we have time to shake out issues before the next release. Regards, Dave Barnes on behalf of the Apache Geode Team
