Hi there Alberto, The ClassLoader Isolation work is currently still in development. Nothing is in the main code-branch yet.
But you are correct. 2 versions. DefaultClassLoaderService will be the standard Java ClassLoader functionality as we are currently used to. The other, JBoss Modules based. Until the ClassLoader Isolation work is completed, the DefaultClassLoaderService will make sure the system works as-is. No changes required. The JBoss modules based ClassLoaderService will initially opt-in under the flag, until we find it to be stable enough to make it the default. But we really want this swapping of ClassLoaders to be simple and seamless. The reason for this RFC is to lay the ground work into the main code base, that would allow us to plug-in a different ClassLoaderService into the main code base. At this stage, from a prototype we’ve done, this “simple” change will touch in excess of 200 classes. Mostly only tests. But you can imagine if this work would be in the same PR as the ClassLoader Isolation work, the PR review would be the worst. Not only would you have to understand the changes suggested / implemented, but also all the classes that have simple, single changes in them. But that does not say that the PR for this RFC would be simple to review either.. As we’d still have the 200+ classes that are touched. —Udo On Sep 15, 2020, 10:33 PM +1000, Alberto Gomez <alberto.go...@est.tech>, wrote: Nice proposal, Udo. Here come some questions: Is the ClassLoader isolation RFC implemented? I have not seen any references to it in the doc or code. To me this RFC seems like a part of the ClassLoader isolation RFC as, without it, the original one would not work completely. Is this right? If I understand correctly, to start with there will be two implementations of the ClassLoaderService, the DefaultClassLoaderService (with the current ClassLoader functionality) and another one with the modular ClassLoader functionality as provided by JBoss modules. The latter one will be used when the --experimental-classloader flag is used in GFSH. Is this right? Thanks, -Alberto G. ________________________________ From: Udo Kohlmeyer <u...@vmware.com> Sent: Monday, September 14, 2020 12:42 PM To: geode <dev@geode.apache.org> Subject: [Discussion] - ClassLoaderService RFC proposal Hi there Apache Geode Devs, (try 2) Please find attached a proposal for a ClassLoaderService. Please review and ponder on it. https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FIntroduction%2Bof%2BClassLoaderService%2Binto%2BGeode&data=02%7C01%7Cudo%40vmware.com%7C0f20f50e1cb14ae271d308d859738aec%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637357700083700083&sdata=lFqZF71ZAVNvEo4FytSqZzpwKAcHuYzj7uuBRiCQ10U%3D&reserved=0 All comments are please to be made in this mail thread. —Udo
