I would vote for 1.13 since that is still up for release, however, I do not see a need for 1.12 as it is not a critical issue.
--Mark On Mon, Aug 3, 2020 at 9:00 AM Dave Barnes <dbar...@apache.org> wrote: > Hard to believe this problem was still hanging around. Definitely > back-port, the sooner, the better. > > On Mon, Aug 3, 2020 at 7:56 AM Dave Barnes <dbar...@apache.org> wrote: > > > +1 > > > > > > On Sun, Aug 2, 2020 at 7:07 AM Donal Evans <doev...@vmware.com> wrote: > > > >> +1 > >> > >> Nice catch! > >> > >> Get Outlook for Android<https://aka.ms/ghei36> > >> > >> ________________________________ > >> From: Jinmei Liao <jil...@vmware.com> > >> Sent: Saturday, August 1, 2020 11:09:45 PM > >> To: dev@geode.apache.org <dev@geode.apache.org> > >> Subject: Re: Proposal to backport GEODE-8395 (gfsh help banner) to > >> support branches > >> > >> +1 > >> > >> On Aug 1, 2020 10:30 PM, Owen Nichols <onich...@vmware.com> wrote: > >> This issue was present since Geode 1.0. There is zero risk from this > >> fix, which is already on develop. It is critical because Geode releases > >> are a legal Act of the Apache Foundation and should not misrepresent the > >> identity of the project. > >> > >> Here’s the issue: > >> > >> $ gfsh > >> _________________________ __ > >> / _____/ ______/ ______/ /____/ / > >> / / __/ /___ /_____ / _____ / > >> / /__/ / ____/ _____/ / / / / > >> /______/_/ /______/_/ /_/ 1.12.0 > >> > >> Monitor and Manage Apache Geode <-- right product name > >> > >> $gfsh --help > >> Pivotal GemFire(R) v1.12.0 Command Line Shell <-- WRONG product name > >> > >> The “right” instance above was fixed 5 years ago. GEODE-8395 fixes gfsh > >> to use the “right” code in both places. Please vote +1 to backport this > >> fix to support/1.13 and support/1.12. > >> > >> > >> >
