OK, Jinmei - we have enough approvals. Go ahead and add this improvement to support/1.13. If it's appropriate for other support branches (I'm not sure in this case) add it to those, too.
Thanks, Dave On 2020/05/20 21:45:33, Karen Miller <kmil...@apache.org> wrote: > +1 for including this documentation in the 1.13 release > > > On Wed, May 20, 2020 at 2:31 PM Dave Barnes <dbar...@apache.org> wrote: > > > Edit completed, reviewed, and committed. > > > > +1 for including this in the 1.13 support branch. > > > > On 2020/05/20 16:54:09, Dave Barnes <dbar...@apache.org> wrote: > > > + 0.5 > > > Good material! I'm in favor of incoporating this doc update in the 1.13 > > support branch, but would like an opportunity to edit for a few > > proof-readerish items that caught my eye. Will submit a PR today for your > > review, Jinmei. Thanks for your contribution! > > > > > > On 2020/05/20 14:09:05, Joris Melchior <jmelch...@vmware.com> wrote: > > > > More documentation is good! > > > > > > > > +1 > > > > ________________________________ > > > > From: Jinmei Liao <jil...@pivotal.io> > > > > Sent: May 19, 2020 14:26 > > > > To: geode <dev@geode.apache.org> > > > > Subject: [PROPOSAL] Bring GEODE-8100 to support branches > > > > > > > > This is to update documentation to better explain the Cluster > > management > > > > service and various geode/system properties that control the behavior > > of > > > > it. It also provides more usage examples in the documentation. There > > is no > > > > product code change in this, but tt would be helpful to the users who > > would > > > > like to understand Cluster management service more. > > > > > > > > -- > > > > Cheers > > > > > > > > Jinmei > > > > > > > > > >
