There is an opportunity to take @Jacob Barrett <jbarr...@pivotal.io>s advice on using a real configuration class instead of an opaque 'Properties' class here. See https://github.com/apache/geode/pull/5115, where we test the API breaking change with an exemption file.
On Thu, May 7, 2020 at 8:52 AM Jacob Barrett <jbarr...@pivotal.io> wrote: > I have some concerns with using Properties in public APIs. The use of > Properties is not strongly typed. I can’ tell from one property to the next > what the type is. I can’t get compile time errors is the type is wrong. I > don’t know what goes into a Property based on the interface or any magic > and IDE could produce. I can’t get compile time failures because I am > missing or using an invalid property. The Property object is synchronized, > so I am using this object to get values frequently I am not serializing all > threads through this object. > > Let’s take this time, where we are already fixing a broken API to do it > right. Build into the API a configuration class that has what we think we > need right now. We can add to that class over time as needed. > > -Jake > > > > On May 4, 2020, at 12:00 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > > > I guess that would have to go into the 1.13 branch as well. This > changes the public API but I think we should do it. The current API isn't > usable since it refers to a non-public interface. > > > > On 5/4/20, 9:31 AM, "Mario Ivanac" <mario.iva...@est.tech> wrote: > > > > Hi all, > > > > after comments that SSLParameterExtension interface has an init() > method that takes a DistributionConfig as an argument (which is internal > class), > > new solution is proposed to replace DistributionConfig with > Properties. > > > > > > New PR is created with new proposal > https://github.com/apache/geode/pull/5040, > > and also RFC is updated with new proposal > https://cwiki.apache.org/confluence/display/GEODE/Introduction+of+SSL+Parameter+Extension > > Introduction of SSL Parameter Extension - Geode - Apache Software > Foundation< > https://cwiki.apache.org/confluence/display/GEODE/Introduction+of+SSL+Parameter+Extension > > > > Hit enter to search. Help. Online Help Keyboard Shortcuts Feed > Builder What’s new > > cwiki.apache.org > > > > Should we cherry-picked this PR into the support/1.12 branch? > > > > Regards, > > Mario > > > > > > > >
