Having just hit this issue myself, and seen it crop up a few times when I was CIO, I think it would definitely be valuable to add some level of Windows testing to PR pre-checkin. It's always better to catch issues early rather than late, and anything that helps keep the pipeline green gets my approval.
Related to this, I personally don't know how to debug a failure and verify a fix for failing Windows tests locally, so being able to push to a PR branch and have that all done for me would be very helpful as well. ________________________________ From: Owen Nichols <onich...@pivotal.io> Sent: Monday, April 27, 2020 1:00 PM To: dev@geode.apache.org <dev@geode.apache.org> Subject: [DISCUSS] should we add some Windows PR checks? Currently we have zero Windows tests in the PR pipeline, which has led to more than a handful of times this year where a PR passed all its checks then failed the main pipeline once merged. Adding these 3 jobs to the PR pipeline would have caught the majority of them: WindowsUnitTestOpenJDK11 WindowsIntegrationTestOpenJDK11 WindowsAcceptanceTestOpenJDK11 The longest of these 3 jobs is about 1/2 hour longer than the current longest PR check. This is a discussion, not a vote thread. This might also be a good chance to reflect on whether more or fewer PR checks should be “required”, whether there are other checks we do not have currently but would be nice, the balance between JDK8 and JDK11 checks, or even brainstorm ideas to create additional checks that might not apply to all PRs but could be requested (or attached automatically based on area of code touched).
