> On Apr 16, 2020, at 2:16 PM, Kirk Lund <kl...@apache.org> wrote:

> Anyone else up for moving them to new src sets? Unfortunately, this alone
> won't make the tests work with the newer versions of Mockito -- and guess
> what, they only OOME in the cloud (not locally).

I could take a stab at it since I split up all the test types originally. I 
should be able to brush off those cobwebs.

> Should I disable these tests?

In an effort to get the Mockito stuff through, yes disable them.

> Should I remove the use of ConcurrentTestRunner from these tests
> (converting them to simple junit tests)?
> 
> I spent some time studying ConcurrentTestRunner and I'm sorry, but I don't
> really see the value in this runner, which is why I want to remove the use
> of it and convert these tests to plain junit tests.

They have less value as unit tests since there are already unit tests that 
cover them. It does raise a good questions about the value and implementation 
of micro concurrent testing like this. I think isolating them away is a good 
step before starting this conversation.


Reply via email to