Merged the revert PR to develop. John or Jens, please have another try (create a new branch from latest develop then revert the revert commit)
Alberto, and anyone else with a PR affected by this, just push an empty commit or another commit to your PR (or merge or rebase latest develop, if you prefer) to get the PR checks to run against the latest develop, then you should be good to go. > On Apr 11, 2020, at 11:52 AM, Alberto Gomez <alberto.go...@est.tech> wrote: > > Owen, I managed to create the revert pull request original pull request page. > > https://github.com/apache/geode/pull/4947 > [https://avatars3.githubusercontent.com/u/47359?s=400&v=4]<https://github.com/apache/geode/pull/4947> > Revert "GEODE-7978: Improve tests for Redis Module SREM Command" by > albertogpz · Pull Request #4947 · > apache/geode<https://github.com/apache/geode/pull/4947> > Reverts #4937 > github.com > > > -Alberto > > ________________________________ > From: Alberto Gomez <alberto.go...@est.tech> > Sent: Saturday, April 11, 2020 8:49 PM > To: dev@geode.apache.org <dev@geode.apache.org> > Subject: Re: Help with Concourse-CI redis integration test failing > > I clicked on the Create Pull Request button but got the following error: > > Pull request creation failed. Validation failed: You can't perform that > action at this time. > > -Alberto > > ________________________________ > From: Owen Nichols <onich...@pivotal.io> > Sent: Saturday, April 11, 2020 8:35 PM > To: dev@geode.apache.org <dev@geode.apache.org> > Subject: Re: Help with Concourse-CI redis integration test failing > > Looks like GitHub creates a branch for the revert as soon as someone clicks > Revert (I didn’t mean to, I just wanted to see what the next screen looks > like, I didn’t click Create Pull Request). > > If I create the pull request, then we need to find a 3rd person to approve > it, so hoping you can still do it... > > Alberto, will it let you click "Create pull request" from here: > https://github.com/apache/geode/compare/revert-4937-feature_parity_redis_srem_command > >> On Apr 11, 2020, at 11:09 AM, Alberto Gomez <alberto.go...@est.tech> wrote: >> >> Thanks Owen. >> >> It seems you already initiated the revert. >> >> Best regards, >> >> -Alberto >> ________________________________ >> From: Owen Nichols <onich...@pivotal.io> >> Sent: Saturday, April 11, 2020 8:04 PM >> To: dev@geode.apache.org <dev@geode.apache.org> >> Subject: Re: Help with Concourse-CI redis integration test failing >> >> Hi Alberto, it looks like Integration tests have been broken since PR#4937 >> was merged at the end of the day Friday. However this PR had passed all its >> PR checks (as of 5 hours before it was merged) so I suspect this was just an >> unexpected interaction with the PR#4912 that came in just 3 hours before it). >> >> In general there is an expectation in the Geode community that when a commit >> breaks the pipeline, it should be reverted first, then fixed. >> >> Alberto, since I don’t think you’re a committer, how about you initiate the >> revert and I’ll approve it? GitHub makes this pretty easy: go to >> https://github.com/apache/geode/pull/4937 and click Revert near the >> bottom-right of the page then click Create pull request. >> >>> On Apr 11, 2020, at 10:01 AM, Alberto Gomez <alberto.go...@est.tech> wrote: >>> >>> Hi, >>> >>> I am seeing the following integration test case fail in the Concourse-CI >>> when executed on my pull request >>> (https://github.com/apache/geode/pull/4928): >>> >>> org.apache.geode.redis.SetsIntegrationTest > >>> testSRem_should_notRemoveMembersOfSetNotSpecified FAILED >>> >>> Interestingly, if I run the test locally it passes. Also, the line of code >>> where the failure occurs does not point to a valid line in the code I see: >>> >>> at >>> org.apache.geode.redis.SetsIntegrationTest.testSRem_should_notRemoveMembersOfSetNotSpecified(SetsIntegrationTest.java:784 >>> >>> Any idea on what could be happening? >>> >>> Thanks in advance, >>> >>> -Alberto G. >> >
