Thanks for catching this, Anthony! The rc pipeline now has a job[1] to check for binaries. Please suggest any other file extensions to check for (it currently checks for .jar .exe .dll .o .so .pyc)
A fix[2] has been pushed to geode-examples to remove the binary you found. I assume we'll want an RC4? If anyone else has any “scriptable” checks that would be nice to bring to the rc pipeline, please share (or add to dev-tools/release/deploy_rc_pipeline.sh yourself). [1] https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc/jobs/verify-no-binaries/builds/9 [2] https://github.com/apache/geode-examples/commit/d3cc0b70884eef7c82fec1a1a284b8250958aac2 > On Mar 26, 2020, at 5:14 PM, Anthony Baker <aba...@pivotal.io> wrote: > > Ernie, > > If you’re planning to spin a new RC can you send a [CANCEL] to let us know? > I’m mid-way through my review of RC2 :-) > > One problem I see is the inclusion of this jar file in a source distribution: > > 🔌 ⌛️ in geode/ > › tar tvf 1.12.0.RC3/apache-geode-examples-1.12.0.tar.gz| grep jar > -rw-r--r-- 0 0 0 56172 Mar 26 15:40 > apache-geode-examples-1.12.0/sessionState/webapp/gradle/wrapper/gradle-wrapper.jar > > I’ve also found a few places where we need to update LICENSE files, but > usually we decide to address those post-release for minor tweaks. > > I’ll report back later tonight on RC3 with more information. > > > Anthony > > > > >> On Mar 26, 2020, at 4:14 PM, Ernest Burghardt <eburgha...@pivotal.io> wrote: >> >> Hello Geode Dev Community, >> >> This is a release candidate for Apache Geode version 1.12.0.RC3. >> Thanks to all the community members for their contributions to this release! >> >> Please do a review and give your feedback, including the checks you >> performed. >> >> Voting deadline: ***** Same as before ***** >> 3PM PST Monday, March 30, 2020. >> >> Please note that we are voting upon the source tag: >> rel/v1.12.0.RC3 >> >> Release notes: >> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0 >> >> Source and binary distributions: >> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC3/ >> >> Maven staging repo: >> https://repository.apache.org/content/repositories/orgapachegeode-1067 >> >> GitHub: >> https://github.com/apache/geode/tree/rel/v1.12.0.RC3 >> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC3 >> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC3 >> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC3 >> >> Pipelines: >> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main >> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc >> >> Geode's KEYS file containing PGP keys we use to sign the release: >> https://github.com/apache/geode/blob/develop/KEYS >> >> Command to run geode-examples: >> ./gradlew -PgeodeReleaseUrl= >> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC3 >> -PgeodeRepositoryUrl= >> https://repository.apache.org/content/repositories/orgapachegeode-1067 >> build runAll >> >> Regards >> Ernie Burghardt >
