Thanks Juan, this is fantastic work discovering and mitigating this! The Benchmarks tests in our pipeline are supposed to catch performance degradations exceeding 5%. We should all be concerned, how did a 7% degradation slip through?
> On Feb 28, 2020, at 3:48 AM, Ju@N <jujora...@gmail.com> wrote: > > Hello devs, > > I'd like to include the fix for GEODE-7820 [1] in release 1.12.0. > The change avoid unnecessary transformations between java collections and > primitive arrays for every message sent within a Geode cluster (see the > Geode tickets for further details). > The SHA is ca7ccbce73d436005fe027f31ee910ee9beeb769 [2]. > My apologies for keep asking to merge changes into an already cut release, > we found a performance degradation (around 7%) within our internal testings > and we're trying to solve it step by step before version 1.12 is released > (we are 3% away from the baseline, Geode 1.10, right now). > Best regards. > > [1]: https://issues.apache.org/jira/browse/GEODE-7820 > [2]: > https://github.com/apache/geode/commit/ca7ccbce73d436005fe027f31ee910ee9beeb769 > > -- > Ju@N
