I've created a PR to ignore this test for now (GEODE-7798 is tracking the problem).
On Wed, Feb 19, 2020 at 9:33 AM Jens Deppe <jde...@pivotal.io> wrote: > Me too :) > > I've had it pass several StressNewTest runs but yet, it seems to still > fail at times. > > On Wed, Feb 19, 2020 at 9:29 AM Kirk Lund <kl...@apache.org> wrote: > >> PubSubTest now fails for me in every PR I submit (3 yesterday). I'm really >> curious how this change made it past PR and into develop. >> >> On Wed, Feb 19, 2020 at 9:18 AM Kirk Lund <kl...@apache.org> wrote: >> >> > PubSubTest is an integration test. Confusion from test names is why I >> > prefer to include *IntegrationTest or *DistributionTest in the name like >> > the wiki prescribes. I recommend naming this test PubSubIntegrationTest. >> > >> > On Wed, Feb 19, 2020 at 9:06 AM Owen Nichols <onich...@pivotal.io> >> wrote: >> > >> >> StressNew is cross-cutting. Unit tests are historically the very least >> >> likely to exhibit windows-specific modes of failure. >> >> >> >> On Wed, Feb 19, 2020 at 9:02 AM Robert Houghton <rhough...@pivotal.io> >> >> wrote: >> >> >> >> > We don't even have windows unit tests for PRs. Walk before we run... >> >> > >> >> > On Wed, Feb 19, 2020, 09:00 Owen Nichols <onich...@pivotal.io> >> wrote: >> >> > >> >> > > Perhaps also worth considering: can we get WindowsStressNew added >> to >> >> the >> >> > PR >> >> > > checks? >> >> > > >> >> > > On Wed, Feb 19, 2020 at 8:50 AM Udo Kohlmeyer <u...@apache.com> >> wrote: >> >> > > >> >> > > > Is this something that can be fixed in a short time (2hrs)? If >> not, >> >> can >> >> > > > be revert and get back to a clean pipeline? >> >> > > > >> >> > > > --Udo >> >> > > > >> >> > > > On 2/19/20 8:23 AM, Jens Deppe wrote: >> >> > > > > Thanks Kirk, >> >> > > > > >> >> > > > > We're working on fixing this. >> >> > > > > >> >> > > > > --Jens >> >> > > > > >> >> > > > > On Tue, Feb 18, 2020 at 3:23 PM Kirk Lund <kl...@pivotal.io> >> >> wrote: >> >> > > > > >> >> > > > >> I just started seeing the Redis PubSubTest fail in >> >> IntegrationTest >> >> > > after >> >> > > > >> rebasing on develop this afternoon. Looks like I have Jens' >> >> latest >> >> > > > commit >> >> > > > >> for this test: >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> >> >> > > > >> *commit 1befce17eaae2403828769840f86639e13fce81f >> (origin/develop, >> >> > > > >> origin/HEAD, develop)Author: Jens Deppe <jde...@pivotal.io >> >> > > > >> <jde...@pivotal.io>>Date: Tue Feb 18 13:03:19 2020 -0800 >> >> > > > GEODE-7798: >> >> > > > >> Fix flaky PubSub test (#4714) * >> >> > > > >> >> >> > > > >> * Authored-by: Jens Deppe <jde...@pivotal.io < >> >> jde...@pivotal.io >> >> > >>> >> >> > > > Task >> >> > > > >> :geode-redis:integrationTest* >> >> > > > >> >> >> > > > >> Here's the stack traces: >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > testPatternWithoutAGlob >> >> FAILED >> >> > > > >> redis.clients.jedis.exceptions.JedisConnectionException: >> >> > > > >> java.net.SocketTimeoutException: Read timed out >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > >> >> >> redis.clients.util.RedisInputStream.ensureFill(RedisInputStream.java:202) >> >> > > > >> at >> >> > > > >> >> >> > >> redis.clients.util.RedisInputStream.readByte(RedisInputStream.java:40) >> >> > > > >> at >> >> redis.clients.jedis.Protocol.process(Protocol.java:151) >> >> > > > >> at >> redis.clients.jedis.Protocol.read(Protocol.java:215) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:340) >> >> > > > >> at >> >> > > > >> >> >> redis.clients.jedis.Connection.getIntegerReply(Connection.java:265) >> >> > > > >> at redis.clients.jedis.Jedis.publish(Jedis.java:2690) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testPatternWithoutAGlob(PubSubTest.java:279) >> >> > > > >> >> >> > > > >> Caused by: >> >> > > > >> java.net.SocketTimeoutException: Read timed out >> >> > > > >> at java.net.SocketInputStream.socketRead0(Native >> >> > Method) >> >> > > > >> at >> >> > > > >> >> java.net.SocketInputStream.socketRead(SocketInputStream.java:115) >> >> > > > >> at >> >> > > > java.net.SocketInputStream.read(SocketInputStream.java:168) >> >> > > > >> at >> >> > > > java.net.SocketInputStream.read(SocketInputStream.java:140) >> >> > > > >> at >> >> > > > java.net.SocketInputStream.read(SocketInputStream.java:126) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > >> >> >> redis.clients.util.RedisInputStream.ensureFill(RedisInputStream.java:196) >> >> > > > >> ... 7 more >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > >> testTwoSubscribersOneChannel >> >> > > FAILED >> >> > > > >> org.awaitility.core.ConditionTimeoutException: Condition >> >> with >> >> > > > lambda >> >> > > > >> expression in org.apache.geode.redis.PubSubTest that uses >> >> > > > >> org.apache.geode.redis.mocks.MockSubscriber was not fulfilled >> >> > within 1 >> >> > > > >> seconds. >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:79) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:27) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860) >> >> > > > >> at >> >> > > > org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testTwoSubscribersOneChannel(PubSubTest.java:140) >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > >> >> > > > >> testOneSubscriberSubscribingToTwoChannels FAILED >> >> > > > >> org.awaitility.core.ConditionTimeoutException: Condition >> >> with >> >> > > > lambda >> >> > > > >> expression in org.apache.geode.redis.PubSubTest that uses >> >> > > > >> org.apache.geode.redis.mocks.MockSubscriber was not fulfilled >> >> > within 1 >> >> > > > >> seconds. >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:79) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:27) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860) >> >> > > > >> at >> >> > > > org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testOneSubscriberSubscribingToTwoChannels(PubSubTest.java:110) >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > >> >> testPatternAndRegularSubscribe >> >> > > > FAILED >> >> > > > >> org.awaitility.core.ConditionTimeoutException: Condition >> >> with >> >> > > > lambda >> >> > > > >> expression in org.apache.geode.redis.PubSubTest that uses >> >> > > > >> org.apache.geode.redis.mocks.MockSubscriber was not fulfilled >> >> > within 1 >> >> > > > >> seconds. >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:79) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:27) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860) >> >> > > > >> at >> >> > > > org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testPatternAndRegularSubscribe(PubSubTest.java:245) >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > testDeadSubscriber FAILED >> >> > > > >> org.junit.ComparisonFailure: expected:<[0]L> but >> was:<[2]L> >> >> > > > >> at >> >> > > > >> >> >> > >> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native >> >> > > > >> Method) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testDeadSubscriber(PubSubTest.java:207) >> >> > > > >> >> >> > > > >> org.apache.geode.redis.PubSubTest > >> >> > > testOneSubscriberOneChannelTwoTimes >> >> > > > >> FAILED >> >> > > > >> org.awaitility.core.ConditionTimeoutException: Condition >> >> with >> >> > > > lambda >> >> > > > >> expression in org.apache.geode.redis.PubSubTest that uses >> >> > > > >> org.apache.geode.redis.mocks.MockSubscriber was not fulfilled >> >> > within 1 >> >> > > > >> seconds. >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:145) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:79) >> >> > > > >> at >> >> > > > >> >> >> > >> org.awaitility.core.CallableCondition.await(CallableCondition.java:27) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:902) >> >> > > > >> at >> >> > > > >> >> >> > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:860) >> >> > > > >> at >> >> > > > org.apache.geode.redis.PubSubTest.waitFor(PubSubTest.java:296) >> >> > > > >> at >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> org.apache.geode.redis.PubSubTest.testOneSubscriberOneChannelTwoTimes(PubSubTest.java:176) >> >> > > > >> >> >> > > > >> 82 tests completed, 6 failed >> >> > > > >> >> >> > > > >> >> > > >> >> > >> >> >> > >> >
