Try setting STATISTIC_SAMPLING_ENABLED to false to disable statistic
sampling.

I think we should delete "An empty string (default) disables statistic
archival." from the javadocs for STATISTIC_ARCHIVE_FILE to avoid confusion
and redundancy with STATISTIC_SAMPLING_ENABLED.

See below for the javadocs on both properties.

  /**
   * The static String definition of the <i>"statistic-archive-file"</i>
property <a
   * name="statistic-archive-file"/a>
   * </p>
   * <U>Description</U>: The file that statistic samples are written to. An
empty string (default)
   * disables statistic archival.
   * </p>
   * <U>Default</U>: ""
   */
  String STATISTIC_ARCHIVE_FILE = "statistic-archive-file";

  /**
   * The static String definition of the
<i>"statistic-sampling-enabled"</i> property <a
   * name="statistic-sampling-enabled"/a>
   * </p>
   * <U>Description</U>: "true" causes the statistics to be sampled
periodically and operating
   * system statistics to be fetched each time a sample is taken. "false"
disables sampling which
   * also disables operating system statistic collection. Non OS statistics
will still be recorded
   * in memory and can be viewed by administration tools. However, charts
will show no activity and
   * no statistics will be archived while sampling is disabled. Starting in
7.0 the default value
   * has been changed to true. If statistic sampling is disabled it will
also cause various metrics
   * seen in gfsh and pulse to always be zero.
   * </p>
   * <U>Default</U>: "true"
   * </p>
   * <U>Allowed values</U>: true|false
   */
  String STATISTIC_SAMPLING_ENABLED = "statistic-sampling-enabled";

On Tue, Jan 21, 2020 at 1:06 AM Mario Kevo <mario.k...@est.tech> wrote:

> Hi,
>
> We are trying to disable archiving statistic in the file by providing
> empty string to --statistic-archive-file. This option doesn't work.
> From the documentation it should work:
> The file to which the running system member writes statistic samples. For
> example: “StatisticsArchiveFile.gfs”. An empty string disables archiving.
> I opened ticket(GEODE-7714<
> https://issues.apache.org/jira/browse/GEODE-7714>) and try to fix it, but
> without success.
>
> As alter runtime command update properties and cache, it checks if any of
> these parameters change, but if we set this property to an empty string it
> failed with message
> Please provide a relevant parameter(s).
> We can change for this parameter that it can be an empty string but how
> this command works, it goes over all parameters and checks if it is
> changed. In that case if we provide something like
> alter runtime --member=server it will be successiful but shouldn't as we
> didn't provide any parameter.
>
> So the proposal is that we need to add a new parameter called
> --statistic-archiving-enabled  which can be true or false. In case it is
> true we need to provide also --statistic-archive-file.
>
> Any thougths?
>
> BR,
> Mario
>
>

Reply via email to