I'm for un-deprecating it. On Fri, Jan 3, 2020 at 7:01 AM Joris Melchior <jmelch...@pivotal.io> wrote:
> Yes, the code indicates that the deprecation is related to the different > QueryService methods but then these methods end up using the IndexType > themselves which is the main reason I want to un-deprecate the ENUM itself. > > The changes to the QueryService interface in the proposal were suggested by > John to make the code show its intentions more clearly. > > On Thu, Jan 2, 2020 at 4:40 PM John Blum <jb...@pivotal.io> wrote: > > > I thought I recall that the IndexType > > < > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/IndexType.html > > > > > [1] > > was *deprecated* in favor of specific methods on the QueryService > > < > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html > > > > > interface > > [2] used to create Indexes of a specific type, e.g. like a Key Index > using > > QueryService.createKeyIndex(..) > > < > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html#createKeyIndex-java.lang.String-java.lang.String-java.lang.String- > > > > > [3] > > (or one of the "overloaded" variants), which is in contrast to the > generic > > createIndex(..) > > < > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html#createIndex-java.lang.String-org.apache.geode.cache.query.IndexType-java.lang.String-java.lang.String-java.lang.String- > > > > > method [4] that accepted the (now deprecated) IndexType Enum as an > > argument. > > > > However, I still feel that the IndexType Enum should NOT be deprecated, > > especially given that the Index.getType():IndexType > > < > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/Index.html#getType-- > > > > > method [5] is quite useful to assess an Index (e.g. think > > Management/Monitoring tools or other analysis tools to ascertain the > > state/configuration of the system). > > > > -j > > > > > > [1] > > > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/IndexType.html > > [2] > > > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html > > [3] > > > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html#createKeyIndex-java.lang.String-java.lang.String-java.lang.String- > > [4] > > > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/QueryService.html#createIndex-java.lang.String-org.apache.geode.cache.query.IndexType-java.lang.String-java.lang.String-java.lang.String- > > [5] > > > > > https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/query/Index.html#getType-- > > > > > > On Thu, Jan 2, 2020 at 1:26 PM Joris Melchior <jmelch...@pivotal.io> > > wrote: > > > > > Hi Kirk, > > > > > > No, I've tried to figure that out but was unsuccessful in doing so. It > > > would be helpful if someone would be able to shed some light on that. > > > > > > > > > On Thu, Jan 2, 2020 at 1:34 PM Kirk Lund <kl...@apache.org> wrote: > > > > > > > Hi Joris, I've read the proposal and reviewed the code some. It's not > > > clear > > > > to me why it was originally deprecated or what the intended new > > direction > > > > (instead of IndexType) was ever going to be. Do you know more about > why > > > it > > > > was deprecated or what the devs were going to replace it with? > > > > > > > > On Thu, Jan 2, 2020 at 6:31 AM Joris Melchior <jmelch...@pivotal.io> > > > > wrote: > > > > > > > > > Apart from Bruce's response (thanks!) it's been very quiet on this > > > item. > > > > > > > > > > I'll extend the response time to Jan 10. > > > > > > > > > > Details at > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135863477 > > > > > > > > > > Thanks, Joris. > > > > > > > > > > On Wed, Dec 4, 2019 at 1:03 PM Bruce Schuchardt < > > > bschucha...@pivotal.io> > > > > > wrote: > > > > > > > > > > > This proposal seems reasonable to me > > > > > > > > > > > > On 12/3/19 10:19 AM, Joris Melchior wrote: > > > > > > > Ah, that makes sense. I will update! > > > > > > > > > > > > > > > > > > > > > On Tue, Dec 3, 2019 at 12:41 PM Alexander Murmann < > > > > amurm...@pivotal.io > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> Joris, the "to be reviewed by" field is for a target date by > > which > > > > to > > > > > > wrap > > > > > > >> up the discussion. Do you mind updating the field and letting > > the > > > > > > mailing > > > > > > >> list know what timeframe you envision? > > > > > > >> > > > > > > >> Thanks! > > > > > > >> > > > > > > >> On Mon, Dec 2, 2019 at 1:41 PM Joris Melchior < > > > jmelch...@pivotal.io > > > > > > > > > > > >> wrote: > > > > > > >> > > > > > > >>> Hi All, > > > > > > >>> > > > > > > >>> Looking for feedback on the proposal to [un/de]deprecate the > > > > > IndexType > > > > > > >> ENUM > > > > > > >>> on Geode. > > > > > > >>> > > > > > > >>> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=135863477 > > > > > > >>> Thanks, Joris. > > > > > > >>> > > > > > > >>> -- > > > > > > >>> *Joris Melchior * > > > > > > >>> CF Engineering > > > > > > >>> Pivotal Toronto > > > > > > >>> 416 877 5427 > > > > > > >>> > > > > > > >>> “Programs must be written for people to read, and only > > > incidentally > > > > > for > > > > > > >>> machines to execute.” – *Hal Abelson* > > > > > > >>> <https://en.wikipedia.org/wiki/Hal_Abelson> > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > *Joris Melchior * > > > > > CF Engineering > > > > > Pivotal Toronto > > > > > 416 877 5427 > > > > > > > > > > “Programs must be written for people to read, and only incidentally > > for > > > > > machines to execute.” – *Hal Abelson* > > > > > <https://en.wikipedia.org/wiki/Hal_Abelson> > > > > > > > > > > > > > > > > > > -- > > > *Joris Melchior * > > > CF Engineering > > > Pivotal Toronto > > > 416 877 5427 > > > > > > “Programs must be written for people to read, and only incidentally for > > > machines to execute.” – *Hal Abelson* > > > <https://en.wikipedia.org/wiki/Hal_Abelson> > > > > > > > > > -- > > -John > > Spring Data Team > > > > > -- > *Joris Melchior * > CF Engineering > Pivotal Toronto > 416 877 5427 > > “Programs must be written for people to read, and only incidentally for > machines to execute.” – *Hal Abelson* > <https://en.wikipedia.org/wiki/Hal_Abelson> >
