+1 On Tue, Dec 17, 2019 at 3:25 PM Dick Cavender <dcaven...@pivotal.io> wrote:
> +1 > > On Tue, Dec 17, 2019 at 3:01 PM Patrick Johnson <pjohn...@pivotal.io> > wrote: > > > +1 > > > > > On Dec 17, 2019, at 2:59 PM, Owen Nichols <onich...@pivotal.io> wrote: > > > > > > +1 > > > > > >> On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer <u...@apache.com> wrote: > > >> > > >> Hi there Apache Devs. > > >> > > >> I can we please vote on the inclusion of GEODE-7159. This issue is to > > fix an bug which assumes that all `Pool` objects are of type `PoolImpl` > and > > immediately casts Pool -> PoolImpl. This issue is related to GEODE-7531, > > and is specific to the emergencyClose method. > > >> > > >> In the case of testing with Mocks, the type casts fail, because the > > Pool-mocks are not of type PoolImpl. The simplest fix (for now) was to > type > > check before the cast. > > >> > > >> > > >> Regards > > >> > > >> Udo > > >> > > > > > > > > -- -John Spring Data Team
