Well lack of review was one part. The major part was that if you click on the checks from the other empty commits, you'll see that the required passing jobs never triggered (only the LGTM checks).
-michael On Fri, Dec 13, 2019 at 11:43 AM Joey McAllister <jmcallis...@pivotal.io> wrote: > Hi Michael, > > That may have been connected, at least in part, to a lack of a review. I > have given my review on adding this info to the README, which I think looks > good, and things seem to have gone green. > > That said, as I mentioned in my review, I also wouldn't mind seeing a > thumbs up (or other feedback) from someone else in the community who will > be using these LGTM alerts regularly. > > Best, > Joey > > On Fri, Dec 13, 2019 at 11:31 AM Michael Oleske <mole...@pivotal.io> > wrote: > > > Hi Geode Dev! > > > > This PR https://github.com/apache/geode/pull/4406 is a change to the > > readme. However it took 3 empty commits to get it to go green enough to > be > > allowed to be merged. This seems odd, especially with just a readme > > change. Is there something going with how CI works for PRs? This was an > > incredibly frustrating experience. > > > > Thanks! > > -michael > > >
