+1

To the extent possible without breaking existing APIs, please name the new 
stuff to indicate what’s in the pool (E.g. ConnectionPool, 
ConnectionPoolService, and so on).

—
Dale Emery
dem...@pivotal.io



> On Dec 5, 2019, at 4:40 PM, Dan Smith <dsm...@pivotal.io> wrote:
> 
> Hi,
> 
> I wrote up a proposal for deprecating of the singleton PoolManager in favor
> of a ClientCache scoped service. Please review and comment on the below
> proposal.
> 
> I think this should address the issues that Spring Data Geode and friends
> had trying to mock Pools and remove the need for those projects to try to
> inject mock Pools into a Geode singleton.
> 
> https://cwiki.apache.org/confluence/display/GEODE/Replace+singleton+PoolManager+with+ClientCache+scoped+service
> 
> Thanks,
> -Dan

Reply via email to