In light of the recent issue with GEODE-7488, I think I should clarify/expand what I said earlier in this thread. While I'm definitely against bypassing PR checks when it's done just for convenience or impatience, I agree with Ben and Udo's stance that in "emergencies" it should be at least considered.
If something is broken in such a way that the ONLY way to fix it is to force through a commit and bypass PR checks then there's not really an argument against that. However, if it's a case of "X test is failing because that test has underlying problems" or something similar, then the solution should be to fix the test and improve the quality of our pipeline rather than just sweep it under the rug. On Fri, Nov 22, 2019 at 12:19 PM Dan Smith <dsm...@pivotal.io> wrote: > On Fri, Nov 22, 2019 at 11:56 AM Owen Nichols <onich...@pivotal.io> wrote: > > > Tallying the votes from this thread, it looks like the majority vote is > to > > NEVER allow override even in extreme circumstance. > > > > I think a better way of summarizing this thread so far is that there isn't > really a consensus on this point, opinions seem to be fairly split. This > wasn't a vote, and not everybody who expressed an opinion put a number next > to their opinion or was directly aligned with the statement above. > > Maybe folks who think there should not be an override option could propose > a specific process for dealing with issues like what Robert just did and > try to bring the rest of us on board with that? > > -Dan >
