-1 based on Blakes feedback. If we need to change the native client tag and source zip, we need to create RC3.
-Dan On Thu, Nov 21, 2019 at 11:31 AM Blake Bender <bben...@pivotal.io> wrote: > We could also just tag the current NC develop branch. I've run all my > integration tests from NC develop branch against 1.11.0.RC2, and it looks > good on Mac, Windows and Linux. > > > On Thu, Nov 21, 2019 at 11:25 AM Blake Bender <bben...@pivotal.io> wrote: > > > If it's a requirement that the native client runs properly, I'm a -1. > > There's a segfault bug in NC logging (see > > https://github.com/apache/geode-native/pull/545), and the release tag is > > prior to the fix. I'd prefer to pick up NC from this commit: > > > https://github.com/apache/geode-native/commit/c932a1d765809dcd8d7a0c0f14a3aa6c98e18a5c > > . > > > > Thanks, > > > > Blake > > > > > > On Wed, Nov 20, 2019 at 5:16 PM Mark Hanson <mhan...@pivotal.io> wrote: > > > >> Hello Geode Dev Community, > >> > >> This is a release candidate for Apache Geode version 1.11.0.RC2. > >> Thanks to all the community members for their contributions to this > >> release! > >> > >> Please do a review and give your feedback, including the checks you > >> performed. > >> > >> Voting deadline: > >> 3PM PST Mon, November 25 2019. > >> > >> Please note that we are voting upon the source tag: > >> rel/v1.11.0.RC2 > >> > >> Release notes: > >> > >> > https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.11.0 > >> > >> Source and binary distributions: > >> https://dist.apache.org/repos/dist/dev/geode/1.11.0.RC2/ > >> > >> Maven staging repo: > >> https://repository.apache.org/content/repositories/orgapachegeode-1062 > >> > >> GitHub: > >> https://github.com/apache/geode/tree/rel/v1.11.0.RC2 > >> https://github.com/apache/geode-examples/tree/rel/v1.11.0.RC2 > >> https://github.com/apache/geode-native/tree/rel/v1.11.0.RC2 > >> > >> Pipelines: > >> > >> > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-11-0-main > >> > >> > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-11-0-rc > >> > >> Geode's KEYS file containing PGP keys we use to sign the release: > >> https://github.com/apache/geode/blob/develop/KEYS > >> > >> Command to run geode-examples: > >> ./gradlew -PgeodeReleaseUrl= > >> https://dist.apache.org/repos/dist/dev/geode/1.11.0.RC2 > >> -PgeodeRepositoryUrl= > >> https://repository.apache.org/content/repositories/orgapachegeode-1062 > >> build runAll > >> > >> > >> >
